ci: add workspace-wide cargo check and clippy jobs#342
Merged
ameya-deshmukh merged 6 commits intoseismicfrom Mar 24, 2026
Merged
ci: add workspace-wide cargo check and clippy jobs#342ameya-deshmukh merged 6 commits intoseismicfrom
ameya-deshmukh merged 6 commits intoseismicfrom
Conversation
Replace the commented-out `cargo build` step with `cargo check --workspace` for faster compilation validation. Add a new `clippy-workspace` job that runs clippy across the entire workspace to catch lint issues early.
Contributor
|
Replaces commented-out cargo build with workspace-wide compilation check in CI. LGTM |
The workspace-wide clippy job fails due to pre-existing warnings in upstream crates (reth-trie-common, reth-trie-db). Remove it for now; keep the cargo check --workspace step which is the primary value add.
Use cargo hack check --workspace instead of cargo check --workspace. cargo hack checks each crate independently, catching issues where shared deps mask per-crate compilation errors. Matches upstream reth.
cargo hack check exposes a pre-existing SerdeBincodeCompat trait bound issue in reth-ethereum-primitives. Revert to cargo check --workspace until the underlying issue is investigated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cargo buildstep withcargo check --workspacefor fast (~30s) workspace-wide compilation validationcargo hack check --workspace(like upstream reth) once the pre-existingSerdeBincodeCompattrait bound issue inreth-ethereum-primitivesis fixedTest plan
cargo check --workspacestep passes in CI🤖 Generated with Claude Code