chore: set the number of threads to the number of cores by default#148
Open
matthias-wright wants to merge 9 commits intomainfrom
Open
chore: set the number of threads to the number of cores by default#148matthias-wright wants to merge 9 commits intomainfrom
matthias-wright wants to merge 9 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the
--worker_threadsCLI argument default toNone. If no argument is passed, then the tokio runtime will use as many threads as there are cores. The number of cores is obtained viastd::thread::available_parallelism().According to the docs,
available_parallelismcan return an error, for example if the amount of parallelism is not known to the target platform, or the program lacks permission to query the amount of parallelism.This should never happen, but in this case the number of threads will default to 4.