Refactor Molecule to support v24 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1-nathangerhart
added a commit
that referenced
this pull request
Jul 29, 2024
* Fix role referenced in readme (#4) * Update README.md (#7) Fixing an small typo at the README file * Refactor Molecule to support v24 (#14) * add product codes for new agent versions * remove product codes for eol windows versions <23 * add Get-MSIProperties script to aid in gathering product codes * upgrade molecule to version 24.6 and refactor scenarios * remove deprecated molecule config from roles * refactor workflows for molecule 24.6 * set role-path to be optional * disable linting to test if refactor works * tweak pip install * set ansible version * fix variable * tweak ansible install * specifically install vagrant dependencies of molecule plugins * uninstall molecule-vagrant * force uninstall * revert install method for ansible * disable linting to validate refactor didn't break things * update action versions * comment molecule lint * increase win_async_startup_timeout * fix ansible-lint errors * test ansible-lint github action * manually configure ansible-lint * fixup yamllint to comply with ansible-lint * fix yamllint violations * fix lint errors * ansible-lit --fix * lint files * standardize role files on ansible-lint v24 rules * cleanup truthy and quotes in molecule scenarios * cleanup workspacefile * add runtime file * ansible-lint --------- Co-authored-by: jhona32423 <[email protected]>
s1-nathangerhart
added a commit
that referenced
this pull request
Jul 29, 2024
* Fix regex for detecting package names Fixes #3 * Fix role referenced in readme (#4) * Update README.md (#7) * Refactor Molecule to support v24 (#14) * add product codes for new agent versions * remove product codes for eol windows versions <23 * add Get-MSIProperties script to aid in gathering product codes * set role-path to be optional * standardize role files on ansible-lint v24 rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor Molecule tests to account for changes that have been introduced in recent versions.