MAX-5172 CRA unable to run tests after install #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove pacakge-lock.json * Update jest setup file location. * Upgrade to enzyme 3.1 and add its adapter. * Update eslint configuration to work align with prettier configuration. * Add a fixed react version(React 16) at template dependencies. * Upgrade react-test-renderer to integrate with React 16. * Load webcomponent polyfills on need. Update webpack configuration & public/index.html template to support application that is not using ui-component-predix, in other words, no need webcomponents polyfills. * Remove unused Link at ContainersList.js * Fix test case issue at Enzyme 3. * Add requestAnimationFrame polyfill to prevent test warnings.
joshsylvester
approved these changes
Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@svmx/react-scriptsdouble install.npm startcompile issue. Update webpack configuration & public/index.html template to load webcomponent polyfills on need, application that don't use ui-component-predix don't need webcomponents polyfills.