Create setup.py and add bot apis #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1.3. ~~美化目录结构和代码格式，提升可维护性。~~ 2.2. ~~excel模板搞一个管理器，支持通过字符串查找模板~~ Signed-off-by: Haphaistos2333 <[email protected]>
added 2 commits
May 3, 2022 05:56
|
感觉就是两处返回错误提示信息的地方，确认下当前这样ok不。其它没看出啥问题，功能ok可以合入 |
|
Please review it and make it merged. |
tongl2
reviewed
May 3, 2022
| parser = excel_parser(open(input_file_path, 'rb')) | ||
| result, errors = parser.parse_for_community(community_parser()) | ||
| if errors: | ||
| return f"以下单元格数据无法识别，请检查:\n{errors}" |
There was a problem hiding this comment.
返回失败和成功的类型都是str，调用者如何分辨这是成功后生成的路径还是错误提示信息呢?
| workbook.save(input_file_path) | ||
| return True | ||
| except Exception as error: | ||
| print(f"Cannot modify file {input_file_path}, error:\n {error}") |
There was a problem hiding this comment.
这条错误信息调用者get不到，这个只在后台打印还是需要用户感知一下？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.