add comment #36
Open
add comment #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shelnutt2
reviewed
Oct 20, 2020
| @@ -1,10 +1,13 @@ | |||
| module github.com/Shelnutt2/db2struct | |||
| module hktk1001/db2struct | |||
There was a problem hiding this comment.
Please revert the mod files (go.mod and go.sum), the changes here look like they are only from your fork?
utils_mysql.go
Outdated
| @@ -95,20 +96,30 @@ func generateMysqlTypes(obj map[string]map[string]string, depth int, jsonAnnotat | |||
| annotations = append(annotations, fmt.Sprintf("gorm:\"column:%s%s\"", key, primary)) | |||
| } | |||
| if jsonAnnotation == true { | |||
| annotations = append(annotations, fmt.Sprintf("json:\"%s\"", key)) | |||
| res :=Lcfirst(Case2Camel(key)) | |||
There was a problem hiding this comment.
For the json changes, it looks like your goal is to support different json name format right? snake case vs camel, etc? If so I believe the behavior should be added as a option the user passes in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add comment
增加数据库的注释