Fixed an infinite loop when selecting desktop icons #97
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that a new
onIconsSelected
function was created on each render, causing the following infinite loop:WinXP()
is called.onIconsSelected
function is passed to<Icons />
.useEffect
is called insideIcons()
, andsetSelectedIcons
is called.setSelectedIcons
triggers a dispatch, causingWinXP()
to be called again.To fix this, I wrapped
setSelectedIcons
withuseCallback
. And while at it, I wrapped all other functions.