Add __hash__ function to SigmaLevel & SigmaStatus
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By implementing __eq__ but not __hash__, the `SigmaLevel` enum can no longer be used as the key of a dictionary (see the second paragraph of this Python documentation (1)). The code for the ATT&CK framework integration was however using it in this way (2), and this was leading to runtime errors in `sigma-cli`. This PR adds in an implementation of __hash__ to allow it to continue to be used as such, and similarly for `SigmaStatus`. 1. https://docs.python.org/3.1/reference/datamodel.html#object.__hash__ 2. https://github.com/SigmaHQ/sigma-cli/blob/main/sigma/analyze/attack.py#L19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By implementing
__eq__but not__hash__, theSigmaLevelenum can no longer be used as the key of a dictionary (see the second paragraph of this Python documentation (1)). The code for the ATT&CK framework integration was however using it in this way (2), and this was leading to runtime errors insigma-cli. This PR adds in an implementation of__hash__to allow it to continue to be used as such, and similarly forSigmaStatus.https://docs.python.org/3.1/reference/datamodel.html#object.__hash__