Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes and additions #20

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Various fixes and additions #20

wants to merge 7 commits into from

Conversation

MosesofEgypt
Copy link
Contributor

Fixes:

  • UnionBlock failing to flush if u_node size is defined by FieldType
  • BytesBuffer failing to seek to offset 0(start of buffer)
  • BytesArrayBuffer failing to initialize _pos on instantiation

Additions:

  • more complete definition for wav audio file
  • ability to use BlockDef.str_to_name as a class method
  • util.desc_variant has the ability to verify replacements are valid based on field sizes
  • util.desc_variant no longer needs name of field specified(taken from replacement desc)

@MosesofEgypt
misc fixes and additions
13166a0 
Fixes:
 UnionBlock failing to flush if u_node size is defined by FieldType
 BytesBuffer failing to seek to offset 0(start of buffer)
 BytesArrayBuffer failing to initialize _pos on instantiation

Additions:
 more complete definition for wav audio file
 ability to use BlockDef.str_to_name as a class method
 util.desc_variant able to verify replacement validity via field sizes
 field name no longer required for util.desc_variant
@MosesofEgypt
update changelog
66c0534
@MosesofEgypt
Update supported versions
14f85f9
@MosesofEgypt
speed optimization on ListBlock.index_by_id
d9c7967
@MosesofEgypt MosesofEgypt force-pushed the various_fixes_and_additions branch from c85ca8a to 0bd59bd Compare January 24, 2025 22:16
@MosesofEgypt MosesofEgypt force-pushed the various_fixes_and_additions branch 2 times, most recently from e6b5621 to 7f79929 Compare January 29, 2025 00:12
@MosesofEgypt
Fix and simplify reading and seeking in olecf/thumbs
d4d91e8 
pylinting to fix various bugs and code smells
@MosesofEgypt MosesofEgypt force-pushed the various_fixes_and_additions branch from 7f79929 to d4d91e8 Compare January 30, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MosesofEgypt