Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent "identity" updates to Senses in the API #1468

Open
susanodd opened this issue Jan 24, 2025 · 1 comment
Open

Prevent "identity" updates to Senses in the API #1468

susanodd opened this issue Jan 24, 2025 · 1 comment
Labels

Comments

@susanodd
Copy link
Collaborator

susanodd commented Jan 24, 2025

Code requirement for #1466, #1461, #1360

The pull request #1485 should fix remaining problems.

The pull request #1499 allows to remove them.

The API update gloss code for the Senses checks whether the "new" senses is the "same" as the already existing senses. If nothing has changed, it ignores the senses. (See #1368, #1417)

Use is made of the "package" value retrieved for senses. This is because SignCollect uses this to fetch all the recently updated glosses every five minutes or so. So the "retrieved" senses value of the "package" is compared to the "new" value in the update request.

This is done to prevent "identity" updates.

This is because the "senses updates" removes the old senses and then creates them again, inside a complex transaction.

Make sure the "new" input "string" or "dict" value is normalised in such a way that it matches the Signbank json encoding of the senses offered by the package when they ought to be the same value. To my knowledge this is done. But with the modifications to the "input", this ought to be confirmed. (#1466 )

@susanodd
Copy link
Collaborator Author

susanodd commented Feb 1, 2025

#1469 (comment)

Send a signal to SignCollect (active) instead of fetching a package (passive).

susanodd added a commit that referenced this issue Feb 6, 2025
…eval

of original value, normalisation of Boolean values. Omit non-updated values from TO DO in pre-update method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant