This repository has been archived by the owner on Mar 10, 2024. It is now read-only.
Add EMI Compat (Fixes #114) #137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There's a weird load order dependent crash on quilt with this, not really sure how to parse it, but the recipe buffers are just complete junk for some reason - https://mclo.gs/hrn0P72 it doesn't always happen, only on specific load orders. NBT crafting loading very early seems to make it pass. |
trying to fix the deserialization client bug
can you tell I'm running out of ideas
This reverts commit d877342.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this was an adventure.
This PR is a bit messy (it includes a merged version of #133) - If you get back and actually want to use this, just let me know what branch to cherry pick and retarget, and I'll get a new PR set up (EMI is only available from 1.18.2 onwards)
So, for starters, as it turns out,
createAdvancedRecipeSyncPacketshas a flipped sign - it only sends packets that are almost over the size limit. So all client operations requiring advanced recipes haven't been working. Fixed that.That was a hell of a mystery to solve! I added a few client logger operations to help it along.
The plugin itself adds brewing and smithing recipes so far and is very simple - the recipe displays aren't flawless, but they're better than nothing, and a more skilled hand could improve them somewhat I think.
Samples:
Of course, also fixes TSmithing #3 and TQuilt #8 alongisde #114