Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added const to store every time, and added ReadOnly to Units dropdown #305

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

SindriTh
Copy link
Contributor

@SindriTh SindriTh commented Dec 1, 2023

No description provided.

@SindriTh SindriTh linked an issue Dec 1, 2023 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@SindriTh
Copy link
Contributor Author

SindriTh commented Dec 2, 2023

Added validation checking, as it had a tendency to fail with the new setup.
Feel free to break it @jbbjarnason.

I have yet to figure out a nice way to handle arrays, this might be the next project on my todo. That would likely fix the visual glitches when removing an item, as well as allowing for hard limits for item counts.

That would of course be a separate PR.

@jbbjarnason jbbjarnason merged commit 2a0c19c into main Dec 5, 2023
16 checks passed
@jbbjarnason jbbjarnason deleted the add_const_to_store branch December 5, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Populate const to config data
2 participants