Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inital draft #587

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Inital draft #587

merged 3 commits into from
Jun 18, 2024

Conversation

omarhogni
Copy link
Contributor

No description provided.

jbbjarnason
jbbjarnason reviewed Jun 13, 2024
View reviewed changes
Copy link
Contributor

@jbbjarnason jbbjarnason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two discussion topics:

  • Where would we like to convert between Meters and Feet etc.
  • Default values for a fmt::arg

docs/design/snitch.md Outdated Show resolved Hide resolved
docs/design/snitch.md Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@omarhogni omarhogni marked this pull request as ready for review June 18, 2024 13:31
@omarhogni omarhogni merged commit b3a4527 into main Jun 18, 2024
10 checks passed
@omarhogni omarhogni deleted the alarm_system branch June 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbbjarnason jbbjarnason jbbjarnason left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omarhogni @jbbjarnason