Skip to content

refactor: refactor the parsing logic #105

refactor: refactor the parsing logic

refactor: refactor the parsing logic #105

Triggered via push November 16, 2024 10:10
Status Success
Total duration 26s
Artifacts

rust-fmt.yml

on: push
Run rustfmt style commit
16s
Run rustfmt style commit
Fit to window
Zoom out
Zoom in

Annotations

21 warnings
Run rustfmt style commit
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/checkout@v3, stefanzweifel/git-auto-commit-action@v4. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
this `if` has identical blocks: src/net/parser/ports.rs#L18
warning: this `if` has identical blocks --> src/net/parser/ports.rs:18:74 | 18 | if udp.get_source() == 53 || udp.get_destination() == 53 { | __________________________________________________________________________^ 19 | | Ok((udp.get_source(), udp.get_destination())) 20 | | } else { | |_________________^ | note: same as this --> src/net/parser/ports.rs:20:24 | 20 | } else { | ________________________^ 21 | | Ok((udp.get_source(), udp.get_destination())) 22 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else = note: `#[warn(clippy::if_same_then_else)]` on by default
this function depends on never type fallback being `()`: fluere-plugin/src/lib.rs#L42
warning: this function depends on never type fallback being `()` --> fluere-plugin/src/lib.rs:42:5 | 42 | pub async fn load_plugins(&self, config: &Config) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748> = help: specify the types explicitly note: in edition 2024, the requirement `!: mlua::FromLua<'_>` will fail --> fluere-plugin/src/lib.rs:85:38 | 85 | ... func.call(argument_table)?; | ^^^^ = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
this function has too many arguments (27/7): fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7) --> fluereflow/src/types/fluereflow.rs:63:5 | 63 | / pub fn new( 64 | | source: IpAddr, 65 | | destination: IpAddr, 66 | | d_pkts: u32, ... | 90 | | tos: u8, 91 | | ) -> FluereRecord { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
returning the result of a `let` binding from a block: fluere-config/src/init.rs#L98
warning: returning the result of a `let` binding from a block --> fluere-config/src/init.rs:98:5 | 97 | let path_config = path_base.join("fluere"); | ------------------------------------------- unnecessary `let` binding 98 | path_config | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 97 ~ 98 ~ path_base.join("fluere") |
unneeded unit expression: fluere-config/src/init.rs#L25
warning: unneeded unit expression --> fluere-config/src/init.rs:25:21 | 25 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
this `if` has identical blocks: src/net/parser/ports.rs#L18
warning: this `if` has identical blocks --> src/net/parser/ports.rs:18:74 | 18 | if udp.get_source() == 53 || udp.get_destination() == 53 { | __________________________________________________________________________^ 19 | | Ok((udp.get_source(), udp.get_destination())) 20 | | } else { | |_________________^ | note: same as this --> src/net/parser/ports.rs:20:24 | 20 | } else { | ________________________^ 21 | | Ok((udp.get_source(), udp.get_destination())) 22 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else = note: `#[warn(clippy::if_same_then_else)]` on by default
this function depends on never type fallback being `()`: fluere-plugin/src/lib.rs#L42
warning: this function depends on never type fallback being `()` --> fluere-plugin/src/lib.rs:42:5 | 42 | pub async fn load_plugins(&self, config: &Config) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748> = help: specify the types explicitly note: in edition 2024, the requirement `!: mlua::FromLua<'_>` will fail --> fluere-plugin/src/lib.rs:85:38 | 85 | ... func.call(argument_table)?; | ^^^^ = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
this function has too many arguments (27/7): fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7) --> fluereflow/src/types/fluereflow.rs:63:5 | 63 | / pub fn new( 64 | | source: IpAddr, 65 | | destination: IpAddr, 66 | | d_pkts: u32, ... | 90 | | tos: u8, 91 | | ) -> FluereRecord { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
returning the result of a `let` binding from a block: fluere-config/src/init.rs#L98
warning: returning the result of a `let` binding from a block --> fluere-config/src/init.rs:98:5 | 97 | let path_config = path_base.join("fluere"); | ------------------------------------------- unnecessary `let` binding 98 | path_config | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 97 ~ 98 ~ path_base.join("fluere") |
unneeded unit expression: fluere-config/src/init.rs#L25
warning: unneeded unit expression --> fluere-config/src/init.rs:25:21 | 25 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
this `if` has identical blocks: src/net/parser/ports.rs#L18
warning: this `if` has identical blocks --> src/net/parser/ports.rs:18:74 | 18 | if udp.get_source() == 53 || udp.get_destination() == 53 { | __________________________________________________________________________^ 19 | | Ok((udp.get_source(), udp.get_destination())) 20 | | } else { | |_________________^ | note: same as this --> src/net/parser/ports.rs:20:24 | 20 | } else { | ________________________^ 21 | | Ok((udp.get_source(), udp.get_destination())) 22 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else = note: `#[warn(clippy::if_same_then_else)]` on by default
this function depends on never type fallback being `()`: fluere-plugin/src/lib.rs#L42
warning: this function depends on never type fallback being `()` --> fluere-plugin/src/lib.rs:42:5 | 42 | pub async fn load_plugins(&self, config: &Config) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748> = help: specify the types explicitly note: in edition 2024, the requirement `!: mlua::FromLua<'_>` will fail --> fluere-plugin/src/lib.rs:85:38 | 85 | ... func.call(argument_table)?; | ^^^^ = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
this function has too many arguments (27/7): fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7) --> fluereflow/src/types/fluereflow.rs:63:5 | 63 | / pub fn new( 64 | | source: IpAddr, 65 | | destination: IpAddr, 66 | | d_pkts: u32, ... | 90 | | tos: u8, 91 | | ) -> FluereRecord { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
returning the result of a `let` binding from a block: fluere-config/src/init.rs#L98
warning: returning the result of a `let` binding from a block --> fluere-config/src/init.rs:98:5 | 97 | let path_config = path_base.join("fluere"); | ------------------------------------------- unnecessary `let` binding 98 | path_config | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 97 ~ 98 ~ path_base.join("fluere") |
unneeded unit expression: fluere-config/src/init.rs#L25
warning: unneeded unit expression --> fluere-config/src/init.rs:25:21 | 25 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default
this `if` has identical blocks: src/net/parser/ports.rs#L18
warning: this `if` has identical blocks --> src/net/parser/ports.rs:18:74 | 18 | if udp.get_source() == 53 || udp.get_destination() == 53 { | __________________________________________________________________________^ 19 | | Ok((udp.get_source(), udp.get_destination())) 20 | | } else { | |_________________^ | note: same as this --> src/net/parser/ports.rs:20:24 | 20 | } else { | ________________________^ 21 | | Ok((udp.get_source(), udp.get_destination())) 22 | | } | |_________________^ = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else = note: `#[warn(clippy::if_same_then_else)]` on by default
this function depends on never type fallback being `()`: fluere-plugin/src/lib.rs#L42
warning: this function depends on never type fallback being `()` --> fluere-plugin/src/lib.rs:42:5 | 42 | pub async fn load_plugins(&self, config: &Config) -> Result<()> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748> = help: specify the types explicitly note: in edition 2024, the requirement `!: mlua::FromLua<'_>` will fail --> fluere-plugin/src/lib.rs:85:38 | 85 | ... func.call(argument_table)?; | ^^^^ = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default
this function has too many arguments (27/7): fluereflow/src/types/fluereflow.rs#L63
warning: this function has too many arguments (27/7) --> fluereflow/src/types/fluereflow.rs:63:5 | 63 | / pub fn new( 64 | | source: IpAddr, 65 | | destination: IpAddr, 66 | | d_pkts: u32, ... | 90 | | tos: u8, 91 | | ) -> FluereRecord { | |_____________________^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments = note: `#[warn(clippy::too_many_arguments)]` on by default
returning the result of a `let` binding from a block: fluere-config/src/init.rs#L98
warning: returning the result of a `let` binding from a block --> fluere-config/src/init.rs:98:5 | 97 | let path_config = path_base.join("fluere"); | ------------------------------------------- unnecessary `let` binding 98 | path_config | ^^^^^^^^^^^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return = note: `#[warn(clippy::let_and_return)]` on by default help: return the expression directly | 97 ~ 98 ~ path_base.join("fluere") |
unneeded unit expression: fluere-config/src/init.rs#L25
warning: unneeded unit expression --> fluere-config/src/init.rs:25:21 | 25 | () | ^^ help: remove the final `()` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit = note: `#[warn(clippy::unused_unit)]` on by default