feat: Updated fluere-plugin/src/downloader.rs
clippy
3 errors, 3 warnings
Details
Results
| Message level | Amount |
|---|---|
| Internal compiler error | 0 |
| Error | 3 |
| Warning | 3 |
| Note | 0 |
| Help | 0 |
Versions
- rustc 1.75.0 (82e1608df 2023-12-21)
- cargo 1.75.0 (1d8b05cdd 2023-11-20)
- clippy 0.1.75 (82e1608 2023-12-21)
Annotations
Check failure on line 23 in fluere-plugin/src/downloader.rs
github-actions / clippy
the trait bound `std::io::Error: std::convert::From<git2::Error>` is not satisfied
error[E0277]: the trait bound `std::io::Error: std::convert::From<git2::Error>` is not satisfied
--> fluere-plugin/src/downloader.rs:23:32
|
23 | Err(e) => return Err(e.into()),
| ^^^^ the trait `std::convert::From<git2::Error>` is not implemented for `std::io::Error`
|
= help: the following other types implement trait `std::convert::From<T>`:
<std::io::Error as std::convert::From<std::ffi::NulError>>
<std::io::Error as std::convert::From<tokio::runtime::blocking::pool::SpawnError>>
<std::io::Error as std::convert::From<std::io::IntoInnerError<W>>>
<std::io::Error as std::convert::From<tokio::task::JoinError>>
<std::io::Error as std::convert::From<std::io::ErrorKind>>
<std::io::Error as std::convert::From<tokio::time::error::Elapsed>>
= note: required for `git2::Error` to implement `std::convert::Into<std::io::Error>`
Check failure on line 20 in fluere-plugin/src/downloader.rs
github-actions / clippy
the trait bound `std::io::Error: std::convert::From<git2::Error>` is not satisfied
error[E0277]: the trait bound `std::io::Error: std::convert::From<git2::Error>` is not satisfied
--> fluere-plugin/src/downloader.rs:20:40
|
20 | Err(e) => return Err(e.into()),
| ^^^^ the trait `std::convert::From<git2::Error>` is not implemented for `std::io::Error`
|
= help: the following other types implement trait `std::convert::From<T>`:
<std::io::Error as std::convert::From<std::ffi::NulError>>
<std::io::Error as std::convert::From<tokio::runtime::blocking::pool::SpawnError>>
<std::io::Error as std::convert::From<std::io::IntoInnerError<W>>>
<std::io::Error as std::convert::From<tokio::task::JoinError>>
<std::io::Error as std::convert::From<std::io::ErrorKind>>
<std::io::Error as std::convert::From<tokio::time::error::Elapsed>>
= note: required for `git2::Error` to implement `std::convert::Into<std::io::Error>`
Check failure on line 18 in fluere-plugin/src/downloader.rs
github-actions / clippy
`?` couldn't convert the error to `std::io::Error`
error[E0277]: `?` couldn't convert the error to `std::io::Error`
--> fluere-plugin/src/downloader.rs:18:77
|
7 | pub fn fetch_from_github(repo_name: &str) -> Result<(), std::io::Error> {
| -------------------------- expected `std::io::Error` because of this
...
18 | remote.fetch(&["refs/heads/*:refs/heads/*"], None, None)?;
| ^ the trait `std::convert::From<git2::Error>` is not implemented for `std::io::Error`
|
= note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
= help: the following other types implement trait `std::convert::From<T>`:
<std::io::Error as std::convert::From<std::ffi::NulError>>
<std::io::Error as std::convert::From<tokio::runtime::blocking::pool::SpawnError>>
<std::io::Error as std::convert::From<std::io::IntoInnerError<W>>>
<std::io::Error as std::convert::From<tokio::task::JoinError>>
<std::io::Error as std::convert::From<std::io::ErrorKind>>
<std::io::Error as std::convert::From<tokio::time::error::Elapsed>>
= note: required for `std::result::Result<(), std::io::Error>` to implement `std::ops::FromResidual<std::result::Result<std::convert::Infallible, git2::Error>>`
Check warning on line 2 in fluere-plugin/src/downloader.rs
github-actions / clippy
this import is redundant
warning: this import is redundant
--> fluere-plugin/src/downloader.rs:2:1
|
2 | use git2;
| ^^^^^^^^^ help: remove it entirely
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
= note: `#[warn(clippy::single_component_path_imports)]` on by default
Check warning on line 91 in fluereflow/src/types/fluereflow.rs
github-actions / clippy
this function has too many arguments (27/7)
warning: this function has too many arguments (27/7)
--> fluereflow/src/types/fluereflow.rs:63:5
|
63 | / pub fn new(
64 | | source: IpAddr,
65 | | destination: IpAddr,
66 | | d_pkts: u32,
... |
90 | | tos: u8,
91 | | ) -> FluereRecord {
| |_____________________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
= note: `#[warn(clippy::too_many_arguments)]` on by default
Check warning on line 75 in fluere-config/src/init.rs
github-actions / clippy
returning the result of a `let` binding from a block
warning: returning the result of a `let` binding from a block
--> fluere-config/src/init.rs:75:5
|
74 | let path_config = path_base.join("fluere");
| ------------------------------------------- unnecessary `let` binding
75 | path_config
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
= note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
|
74 ~
75 ~ path_base.join("fluere")
|