Skip to content

build: bump pcap-rs, tokio #471

build: bump pcap-rs, tokio

build: bump pcap-rs, tokio #471

GitHub Actions / clippy succeeded Oct 4, 2024 in 0s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.81.0 (eeb90cda1 2024-09-04)
  • cargo 1.81.0 (2dbb1af80 2024-08-20)
  • clippy 0.1.81 (eeb90cd 2024-09-04)

Annotations

Check warning on line 106 in src/net/offline_fluereflows.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `Key` which implements the `Copy` trait

warning: using `clone` on type `Key` which implements the `Copy` trait
   --> src/net/offline_fluereflows.rs:106:35
    |
106 | ...                   .push(key_value.clone());
    |                             ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `key_value`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy

Check warning on line 105 in src/net/offline_fluereflows.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert_with` to construct default value

warning: use of `or_insert_with` to construct default value
   --> src/net/offline_fluereflows.rs:105:30
    |
105 | ...                   .or_insert_with(Vec::new)
    |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default

Check warning on line 94 in src/net/offline_fluereflows.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

using `clone` on type `Key` which implements the `Copy` trait

warning: using `clone` on type `Key` which implements the `Copy` trait
  --> src/net/offline_fluereflows.rs:94:39
   |
94 | ...                   .push(key_value.clone());
   |                             ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `key_value`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
   = note: `#[warn(clippy::clone_on_copy)]` on by default

Check warning on line 93 in src/net/offline_fluereflows.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

use of `or_insert_with` to construct default value

warning: use of `or_insert_with` to construct default value
  --> src/net/offline_fluereflows.rs:93:34
   |
93 | ...                   .or_insert_with(Vec::new)
   |                        ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
   = note: `#[warn(clippy::unwrap_or_default)]` on by default

Check warning on line 17 in src/net/parser/keys.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `pnet::packet::tcp::TcpPacket`

warning: unused import: `pnet::packet::tcp::TcpPacket`
  --> src/net/parser/keys.rs:17:5
   |
17 | use pnet::packet::tcp::TcpPacket;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 13 in src/net/parser/keys.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `pnet::packet::icmp::IcmpPacket`

warning: unused import: `pnet::packet::icmp::IcmpPacket`
  --> src/net/parser/keys.rs:13:5
   |
13 | use pnet::packet::icmp::IcmpPacket;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Check warning on line 10 in src/net/parser/keys.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused import: `pnet::packet::dns::DnsPacket`

warning: unused import: `pnet::packet::dns::DnsPacket`
  --> src/net/parser/keys.rs:10:5
   |
10 | use pnet::packet::dns::DnsPacket;
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

Check warning on line 42 in fluere-plugin/src/lib.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function depends on never type fallback being `()`

warning: this function depends on never type fallback being `()`
  --> fluere-plugin/src/lib.rs:42:5
   |
42 |     pub async fn load_plugins(&self, config: &Config) -> Result<()> {
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release!
   = note: for more information, see issue #123748 <https://github.com/rust-lang/rust/issues/123748>
   = help: specify the types explicitly
note: in edition 2024, the requirement `!: mlua::FromLua<'_>` will fail
  --> fluere-plugin/src/lib.rs:85:38
   |
85 | ...                   func.call(argument_table)?;
   |                            ^^^^
   = note: `#[warn(dependency_on_unit_never_type_fallback)]` on by default

Check warning on line 91 in fluereflow/src/types/fluereflow.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (27/7)

warning: this function has too many arguments (27/7)
  --> fluereflow/src/types/fluereflow.rs:63:5
   |
63 | /     pub fn new(
64 | |         source: IpAddr,
65 | |         destination: IpAddr,
66 | |         d_pkts: u32,
...  |
90 | |         tos: u8,
91 | |     ) -> FluereRecord {
   | |_____________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 98 in fluere-config/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

returning the result of a `let` binding from a block

warning: returning the result of a `let` binding from a block
  --> fluere-config/src/init.rs:98:5
   |
97 |     let path_config = path_base.join("fluere");
   |     ------------------------------------------- unnecessary `let` binding
98 |     path_config
   |     ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
   = note: `#[warn(clippy::let_and_return)]` on by default
help: return the expression directly
   |
97 ~     
98 ~     path_base.join("fluere")
   |

Check warning on line 25 in fluere-config/src/init.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded unit expression

warning: unneeded unit expression
  --> fluere-config/src/init.rs:25:21
   |
25 |                     ()
   |                     ^^ help: remove the final `()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit
   = note: `#[warn(clippy::unused_unit)]` on by default