-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update new-matter-lock driver #1911
base: main
Are you sure you want to change the base?
Conversation
Duplicate profile check: Passed - no duplicate profiles detected. |
Invitation URL: |
Test Results 64 files ± 0 410 suites ±0 0s ⏱️ ±0s Results for commit ac1c841. ± Comparison against base commit d649f75. This pull request removes 2 tests.
♻️ This comment has been updated with latest results. |
Minimum allowed coverage is Generated by 🐒 cobertura-action against ac1c841 |
ad6655a
to
6ebe1a5
Compare
Can you add a unit test to ensure the battery profiling works as expected for these new profiles? |
should we close this PR then? https://github.com/SmartThingsCommunity/SmartThingsEdgeDrivers/pull/1880/files |
@hcarter-775 |
6ebe1a5
to
4a8a036
Compare
- Add Visible Condition to some profiles that have unlatched - Add some profiles for unlatch feature Signed-off-by: Hunsup Jung <[email protected]>
4a8a036
to
ac1c841
Compare
@hcarter-775
As above error log, There's a problem that lua_libs doesn't support deviceConfig in profile files. We need to update lua_libs to solve this issue. |
Type of Change
Checklist
Description of Change
Issue
User is allowed to lock or unlock from the device card if door lock status is unlatched, but user is not allowed to do the same from Plugin.
Solution
Add Visible Condition to the profiles that have unlatched status
Changes
Add Visible Condition to the profiles that have unlatched status
Add some profiles for unlatch feature
Summary of Completed Tests