Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG2-4037 Z-Wave Thermostat: Whole number workaround #1984

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

greens
Copy link
Contributor

@greens greens commented Mar 6, 2025

Some z-wave thermostats are choking when told to be set to non-whole numbers. This fixes our base behavior for values that aren't half degrees (which are usually celsius).

Intended to be temporary

Check all that apply

Type of Change

  • WWST Certification Request
    • If this is your first time contributing code:
      • I have reviewed the README.md file
      • I have reviewed the CODE_OF_CONDUCT.md file
      • I have signed the CLA
    • I plan on entering a WWST Certification Request or have entered a request through the WWST Certification console at developer.smartthings.com
  • Bug fix
  • New feature
  • Refactor

Checklist

  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have verified my changes by testing with a device or have communicated a plan for testing
  • I am adding new behavior, such as adding a sub-driver, and have added and run new unit tests to cover the new behavior

Description of Change

Summary of Completed Tests

Some z-wave thermostats are choking when told to be set to non-whole numbers. This fixes our base behavior for values that aren't half degrees (which are usually celsius).

Intended to be temporary
@greens greens requested review from dljsjr, cjswedes, ctowns and wkhenon March 6, 2025 21:55
Copy link

github-actions bot commented Mar 6, 2025

Copy link

github-actions bot commented Mar 6, 2025

Test Results

   64 files    414 suites   0s ⏱️
2 092 tests 2 092 ✅ 0 💤 0 ❌
3 584 runs  3 584 ✅ 0 💤 0 ❌

Results for commit d1c23a2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Mar 6, 2025

File Coverage
All files 90%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/ct100-thermostat/init.lua 94%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/thermostat-heating-battery/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/fibaro-heat-controller/init.lua 78%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/aeotec-radiator-thermostat/init.lua 78%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/init.lua 98%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/popp-radiator-thermostat/init.lua 85%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/stelpro-ki-thermostat/init.lua 93%
/home/runner/work/SmartThingsEdgeDrivers/SmartThingsEdgeDrivers/drivers/SmartThings/zwave-thermostat/src/apiv6_bugfix/init.lua 69%

Minimum allowed coverage is 90%

Generated by 🐒 cobertura-action against d1c23a2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants