-
Notifications
You must be signed in to change notification settings - Fork 213
Added a simple http+json server option for monitoring purposes #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@Snipa22 did you try this? looks good to me, but im a noob! |
Do you have a link to a demo of it in action, or at least some screenshots? |
@@ -803,7 +810,8 @@ function Miner(id, params, ip, pushMessage, portData, minerSocket) { | |||
lastShare: this.lastShareTime, | |||
coin: this.coin, | |||
pool: this.pool, | |||
id: this.id | |||
id: this.id, | |||
password: this.password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also add this.login here?
@@ -578,7 +579,13 @@ function balanceWorkers(){ | |||
} | |||
} | |||
|
|||
function enumerateWorkerStats(){ | |||
function enumerateWorkerStats() { | |||
// here we do a bit of a hack and "cache" the activeWorkers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should check for global.config.httpEnable before dumping to disk. Maybe even start a different timeout function and not re-use enumerateWorkerStats
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know where else in the app loop "activeWorkers" is properly defined, and I haven't tried too hard to figure it out, hence the "hack."
@mike-teehan But there is a problem:
|
@FranzDE if you want us to diagnose networking issues for you, you'll need to post some network info. Maybe a screenshot of the Network tab of Dev Tools after you've loaded the info page. Something. Also, new branch, please update: |
@mike-teehan hi Mike, sorry it was my mistake. do you think it is possible to make the miner remain on the list even when it is disconnected? Like this page "proxy-stat.php" that works on "xmrig-proxy":
|
Hi @mike-teehan @Snipa22 |
In the mean time of waiting Snipa merging this PR (he is very busy with works now). Anyone wants to try http / json to monitor workerID, you can use MoneroOcean fork here https://github.com/MoneroOcean/xmr-node-proxy |
@bobbieltd will it notify when a miner disconnects or will it save offline miners(name and IP and etc.)? |
Email feature will be added to notify about miner disconnection (waiting for MO), still in discussion. |
@bobbieltd Could you give a little guidance on what steps need to be taken to get output like yours? Thanks in advance. |
@phubbard91 You don’t need any guidance. Install MoneroOcean XNP fork and change some parameters in config.json for http. |
it's a little undercooked... but it works.