Skip to content

Commit

Permalink
chore: Update docs and migration guide (#3313)
Browse files Browse the repository at this point in the history
- Update docs and migration guide
- Bump tracking version
- Fix method usage after merge (method has been removed)
- Fix whitespace
- Fix link
- Improve function and procedure examples (multiline)

References: #3303 #3302 #3298
  • Loading branch information
sfc-gh-asawicki authored and sfc-gh-jcieslak committed Jan 20, 2025
1 parent e98ce81 commit 6c7ce6c
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
4 changes: 2 additions & 2 deletions pkg/resources/account_parameter_acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ func TestAcc_AccountParameter_ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES(t *testi
CheckDestroy: acc.CheckAccountParameterUnset(t, sdk.AccountParameterRequireStorageIntegrationForStageCreation),
Steps: []resource.TestStep{
{
Config: config.FromModel(t, model),
Config: config.FromModels(t, model),
Check: assert.AssertThat(t, resourceassert.AccountParameterResource(t, model.ResourceReference()).
HasKeyString(string(sdk.AccountParameterRequireStorageIntegrationForStageCreation)).
HasValueString("true"),
Expand All @@ -163,7 +163,7 @@ func TestAcc_AccountParameter_INITIAL_REPLICATION_SIZE_LIMIT_IN_TB(t *testing.T)
CheckDestroy: acc.CheckAccountParameterUnset(t, sdk.AccountParameterInitialReplicationSizeLimitInTB),
Steps: []resource.TestStep{
{
Config: config.FromModel(t, model),
Config: config.FromModels(t, model),
Check: assert.AssertThat(t, resourceassert.AccountParameterResource(t, model.ResourceReference()).
HasKeyString(string(sdk.AccountParameterInitialReplicationSizeLimitInTB)).
HasValueString("3.0"),
Expand Down
1 change: 0 additions & 1 deletion pkg/sdk/parameters.go
Original file line number Diff line number Diff line change
Expand Up @@ -1216,7 +1216,6 @@ func (v *AccountParameters) validate() error {
if err != nil || value < 0 {
return fmt.Errorf("InitialReplicationSizeLimitInTB must be a non-negative float, got %v", *v.InitialReplicationSizeLimitInTB)
}

}
if valueSet(v.MinDataRetentionTimeInDays) {
if !validateIntInRangeInclusive(*v.MinDataRetentionTimeInDays, 0, 90) {
Expand Down

0 comments on commit 6c7ce6c

Please sign in to comment.