chore: Fix docs and update the protected users list #3365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are canceled for now - the sweepers are adjusted. They will be resumed after getting approval. |
sfc-gh-asawicki
approved these changes
Jan 30, 2025
MIGRATION_GUIDE.md
Outdated
| ## v1.0.2 ➞ v1.0.3 | ||
|
|
||
| ### Fixed ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES parameter | ||
| ENFORCE_NETWORK_RULES_FOR_INTERNAL_STAGES account parameter did not work correctly before. This resulted in invalid SQL used during altering accounts. It has been fixed in this version. |
There was a problem hiding this comment.
Please link the issue and explain what was not working (was it incorrect type, right?)
| @@ -452,7 +452,7 @@ func CreateView(orReplace bool) schema.CreateContextFunc { | |||
| } | |||
| err := client.Views.Alter(ctx, sdk.NewAlterViewRequest(id).WithSetDataMetricSchedule(*req)) | |||
| if err != nil { | |||
| return diag.FromErr(fmt.Errorf("error setting data matric schedule in view %v err = %w", id.Name(), err)) | |||
| return diag.FromErr(fmt.Errorf("error setting data metric schedule in view %v err = %w", id.Name(), err)) | |||
There was a problem hiding this comment.
nice copy paste before :D
sfc-gh-jcieslak
approved these changes
Jan 30, 2025
| @@ -233,8 +233,6 @@ func nukeUsers(client *Client) func() error { | |||
| "JAN_CIESLAK_LEGACY", | |||
| "TERRAFORM_SVC_ACCOUNT", | |||
| "TEST_CI_SERVICE_USER", | |||
| "FILIP_BUDZYNSKI", | |||
|
Integration tests failure for 88fa9da032b917ee79c9989ce4840cd13a388b00 |
|
Integration tests cancelled for 07d4dcb736579f01016d33dc7eb4484e41696151 |
|
Integration tests failure for 098eafe82c7ec639ddfd3915432107ea9874e8a2 |
sfc-gh-jcieslak
pushed a commit
that referenced
this pull request
Feb 5, 2025
🤖 I have created a release *beep* *boop* --- ## [1.0.3](v1.0.2...v1.0.3) (2025-02-05) ### 🔧 **Misc** * Add basic performance tests ([#3349](#3349)) ([c57346b](c57346b)) * Add notes about managing grants on hybrid table ([#3368](#3368)) ([e5e98bd](e5e98bd)) * Add preview and stable categories to resources and data sources in docs ([#3370](#3370)) ([b061434](b061434)) * Fix docs and update the protected users list ([#3365](#3365)) ([f23e8cb](f23e8cb)) * Grant ownership common use cases ([#3356](#3356)) ([97813b6](97813b6)) * Metric level fix with object renaming guide ([#3376](#3376)) ([629ff92](629ff92)) * Move technical guides to the guide directory ([#3371](#3371)) ([2b95809](2b95809)) * Prepare authentication methods guide ([#3364](#3364)) ([c4a1c5f](c4a1c5f)) * Publish Performance tests summary ([#3359](#3359)) ([d30d002](d30d002)) * Resolve issues and document account resource ([#3360](#3360)) ([46b7a9d](46b7a9d)) * Upgrade tfplugindocs ([#3361](#3361)) ([89f2b0a](89f2b0a)) ### 🐛 **Bug fixes:** * change EnforceNetworkRulesForInternalStages ddl to parameter ([#3343](#3343)) ([beb01c7](beb01c7)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: snowflake-release-please[bot] <105954990+snowflake-release-please[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
References