Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit issue 6: Use primary governance channel #1050

Merged
merged 1 commit into from
Dec 16, 2023
Merged

Audit issue 6: Use primary governance channel #1050

merged 1 commit into from
Dec 16, 2023

Conversation

vgeddes
Copy link
Collaborator

@vgeddes vgeddes commented Dec 14, 2023

Send force_update_channel and force_transfer_native_from_agent commands via primary governance channel.

In parachain/pallets/system/src/lib.rs:489-490, forceful channel updates, which include actions such as pausing or resuming a channel and adjusting usage fees, are currently directed through the secondary governance channel.

However, updates for the primary governance channel are being dispatched through the same channel as updates for all other channels.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (738ae56) 81.27% compared to head (55df029) 81.27%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1050   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files          54       54           
  Lines        2238     2238           
  Branches       71       71           
=======================================
  Hits         1819     1819           
  Misses        402      402           
  Partials       17       17           
Flag Coverage Δ
rust 81.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@yrong yrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vgeddes vgeddes merged commit 9959866 into main Dec 16, 2023
7 checks passed
@vgeddes vgeddes deleted the audit-issue-6 branch December 16, 2023 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants