Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set gateway on start-up #1054

Merged
merged 4 commits into from
Dec 16, 2023
Merged

Set gateway on start-up #1054

merged 4 commits into from
Dec 16, 2023

Conversation

alistair-singh
Copy link
Contributor

Polkadot-sdk: Snowfork/polkadot-sdk#66

echo "Setting gateway contract"
local storage_key=$(echo $GATEWAY_STORAGE_KEY | cut -c3-)
local gateway=$(echo $GATEWAY_PROXY_CONTRACT | cut -c3-)
local transact_call="0x00040440"$storage_key"50"$gateway
Copy link
Contributor

@yrong yrong Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! I would assume it's a System::set_storage() call and just curious how to generate the storage_key here, any script for that?

Copy link
Contributor Author

@alistair-singh alistair-singh Dec 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

@vgeddes vgeddes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@@ -68,6 +68,7 @@ async fn send_token_to_penpal() {
weth.address(),
PENPAL_PARA_ID,
i_gateway::MultiAddress { kind: 1, data: FERDIE.into() },
4_000_000_000,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@alistair-singh alistair-singh force-pushed the alistair/gateway-in-storage branch from 4dd7640 to d642e31 Compare December 16, 2023 10:09
Copy link

codecov bot commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ffe241f) 81.29% compared to head (efa4cce) 81.29%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1054   +/-   ##
=======================================
  Coverage   81.29%   81.29%           
=======================================
  Files          54       54           
  Lines        2240     2240           
  Branches       71       71           
=======================================
  Hits         1821     1821           
  Misses        402      402           
  Partials       17       17           
Flag Coverage Δ
rust 81.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alistair-singh alistair-singh merged commit f7f06d2 into main Dec 16, 2023
7 checks passed
@alistair-singh alistair-singh deleted the alistair/gateway-in-storage branch December 16, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants