V2 #1371
Open
V2 #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* v2 initial commit * latest changes * Flesh out dispatch logic for inbound messages * Add reward address * make code compile * Split initializer impl into a library to reduce contract size * Major refactor * Update tests * add scripts back * Update scripts * Finish outbound messaging * Implement token registration for V2 * Make functions payable * improve docs * comments * review feedback * cleanups * Add initial tests for V2 * Make `rewardAddress` an indexed event parameter * Clean up interfaces * Make WETH address configurable * Autowrap ether * auto-unwrap ether * Add view keyword * off-chain part * off-chain changes * improve * improve * allow unlocking native ether * improve token registration flows * improve docs * improve * improve * nit * Update contracts/src/v1/Calls.sol Co-authored-by: Clara van Staden <[email protected]> * Apply suggestions from code review Co-authored-by: Alistair Singh <[email protected]> * Fix unlock WETH * Suppress Error (6243): The "tload" instruction * Merge recent changes * add foundry setting * relayer progress * fixes * adds xcm * register token v2 * clean up register token smoketest * fmt * merge damage * fix tests * send token and relayer fixes * relayer cleanup and transact * send token to penpal smoke test * syntax error * adds penpal test to ci * merge damage fixes --------- Co-authored-by: Vincent Geddes <[email protected]> Co-authored-by: ron <[email protected]> Co-authored-by: Alistair Singh <[email protected]>
|
Cool! |
|
@yrong yes please! :D |
* v2 initial commit * latest changes * Flesh out dispatch logic for inbound messages * Add reward address * make code compile * Split initializer impl into a library to reduce contract size * Major refactor * Update tests * add scripts back * Update scripts * Finish outbound messaging * Implement token registration for V2 * Make functions payable * improve docs * Parachain relayer V2 * Rename to PendingOrder * Decode compact int * comments * Improve doc * review feedback * cleanups * Add initial tests for V2 * Make `rewardAddress` an indexed event parameter * Remove unused * Submit delivery proof * Rename to InboundMessageV2 * Mark as view function * Filter with reward address * Clean up interfaces * Make WETH address configurable * Autowrap ether * V2 smoke tests (#1327) * Update contracts for smoke tests * Remove unused * Decode test * Update subxt * Register PNA with OutbountQueueV2 * Fix storage key * Comment out config * Revert contract changes * Fix function * Regenerate binds & update package path * Format * Format * Add todo * Update bindings * Update script * auto-unwrap ether * Update smoke tests * Add view keyword * More refactoring * Verify V2 digest for commitment * Call Contract with value * improve * improve * allow unlocking native ether * improve token registration flows * improve docs * improve * improve * nit * Fix smoke test for V2 * Fix test * Fix unlock WETH * Sync with contract * Fix smoke test * Update contracts/src/v1/Calls.sol Co-authored-by: Clara van Staden <[email protected]> * Apply suggestions from code review Co-authored-by: Alistair Singh <[email protected]> * Fix unlock WETH * Suppress Error (6243): The "tload" instruction * Merge recent changes * Fix breaking tests * Fix tests * Filter order by rewardAddress to handle own delivery proof * Fix test * Add ofac check --------- Co-authored-by: Vincent Geddes <[email protected]> Co-authored-by: Clara van Staden <[email protected]> Co-authored-by: Alistair Singh <[email protected]>
| privateKey string | ||
| privateKeyFile string | ||
| privateKeyID string | ||
| parachainPrivateKey string |
There was a problem hiding this comment.
@yrong do we still need the substrate private key for the parachain relayer? Maybe for the delivery proofs? I don't see it in your Parachain Relayer V2 PR anymore, but perhaps it was in the v2 branch already.
Reason why I am asking is I want to add the key to the start-relayer scripts but just want to make sure it is still necessary.
There was a problem hiding this comment.
Yeah, we need that for submitting delivery proofs to BH.
I wrap a script specific for the V2 message relayer in https://github.com/Snowfork/snowbridge/blob/v2/web/packages/test/scripts/start-relayer-v2.sh and test by running a legacy V1 relayer side by side with the V2 message relayer.
In that way, I can test the V1 smoke tests still work as expected for the V2 setup, which means it's fully compatible.
Anyway, feel free to add that to start-relayer scripts.
* Fix smoke tests * Add smoke tests * Prefund transfer ENA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.