scan create: allow maven files, include cwd option #319
+50
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdz
commented
Feb 13, 2025
src/commands/scan/create.ts
Outdated
|
|
||
| const packagePaths = await getPackageFilesFullScans( | ||
| cwd, | ||
| cli.input, |
Contributor
Author
There was a problem hiding this comment.
This would have sent the org as part of potential folders (which probably would lead to an error? or accidental include maybe?). Not sure how blocking this was but it's fixed now.
pvdz
changed the title
jdalton
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This works my way through the
socket scan createcommand and ... gets it to work.Okay. First create a pom.xml and store it somewhere. I've stored it in
~/tmp/okay/pom.xmlNext, run this:
(The
npm execonly for dev stuff)You'll need to login as usual. The repo and branch dont seem to matter. tmp makes it a temporary scan (?). cwd is mandatory here since in cli dev I can't move to a different folder and various pieces hard require a cwd.
This will lead to an upload like https://socket.dev/dashboard/org/SocketDev/sbom/b48218c6-2d93-40b6-b343-a0dc6e1150df?tab=dependencies
... profit.