Skip to content

Refactor package filename to handle-* fetch-* and output-* #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

pvdz
Copy link
Collaborator

@pvdz pvdz commented Mar 20, 2025

Started to realize an emerging pattern;

Command file does initial handling, then usually fetches (or collects) data before displaying (or transmitting) it.

Going to make that more consistent in all commands, here's a sample: use handle- for the "bridging" file. Basically this is the command being invoked without the input handling/validation. Or put differently, everything that happens after dry-run exits.

Then there's a fetch-* file for collecting the data from the API. This may be different for files that collect data from disk or whatever but at least most of the "get-" should become "fetch-".

And the last file is output-* to display the result to the user, or to write it to disk or something.

I suspect that most fetch- stuffs can be abstracted pretty decently as part of our sdk interface, but there are some edge cases to take care of so we'll see if that holds.

Also updated some logic to be able to test locally.

@pvdz pvdz changed the title Refactor Refactor package filename to handle-* fetch-* and output-* Mar 20, 2025
@pvdz pvdz requested a review from jdalton March 20, 2025 14:05
@jdalton jdalton merged commit cbbd8c2 into main Mar 20, 2025
17 checks passed
@jdalton jdalton deleted the refactor_0320 branch March 20, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants