SONARJS-805 Add 3 more methods for Ember.js (#392)

SonarSource · Nov 8, 2016 · 0e2c19b · 0e2c19b
1 parent 44e9cf2
commit 0e2c19b
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 0 deletions.
diff --git a/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3759.html b/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3759.html
@@ -13,6 +13,9 @@ <h2>Exceptions</h2>
   <li> <code>classify</code> </li>
   <li> <code>dasherize</code> </li>
   <li> <code>decamelize</code> </li>
+  <li> <code>fmt</code> </li>
+  <li> <code>loc</code> </li>
   <li> <code>underscore</code> </li>
+  <li> <code>w</code> </li>
 </ul>
 
diff --git a/javascript-checks/src/test/resources/checks/NonExistentPropertyAccess.js b/javascript-checks/src/test/resources/checks/NonExistentPropertyAccess.js
@@ -64,5 +64,8 @@ function ember_api() {
   "foo".classify();
   "foo".dasherize();
   "foo".decamelize();
+  "foo".fmt();
+  "foo".loc();
   "foo".underscore();
+  "foo".w();
 }
diff --git a/...ript-frontend/src/main/java/org/sonar/javascript/se/builtins/StringBuiltInProperties.java b/...ript-frontend/src/main/java/org/sonar/javascript/se/builtins/StringBuiltInProperties.java
@@ -85,7 +85,10 @@ Map<String, SymbolicValue> getMethods() {
       .put("classify", method(Constraint.STRING_PRIMITIVE))
       .put("dasherize", method(Constraint.STRING_PRIMITIVE))
       .put("decamelize", method(Constraint.STRING_PRIMITIVE))
+      .put("fmt", method(Constraint.STRING_PRIMITIVE))
+      .put("loc", method(Constraint.STRING_PRIMITIVE))
       .put("underscore", method(Constraint.STRING_PRIMITIVE))
+      .put("w", method(Constraint.ARRAY))
       .build();
   }
 

diff --git a/...script-frontend/src/test/java/org/sonar/javascript/se/builtins/BuiltInPropertiesTest.java b/...script-frontend/src/test/java/org/sonar/javascript/se/builtins/BuiltInPropertiesTest.java
@@ -47,6 +47,7 @@ public void test_string() throws Exception {
   public void test_ember_string_extension() throws Exception {
     type = Type.STRING_PRIMITIVE;
     assertMethod(value("camelize"), method(Constraint.STRING_PRIMITIVE));
+    assertMethod(value("w"), method(Constraint.ARRAY));
   }
 
   @Test