Update rules metadata (#4856)

css-sonarpedia/sonarpedia.json

@@ -3,7 +3,7 @@
   "languages": [
     "CSS"
   ],
-  "latest-update": "2024-09-17T13:10:55.911474Z",
+  "latest-update": "2024-09-25T13:47:31.326757900Z",
   "options": {
     "no-language-in-filenames": true
   }

packages/jsts/src/rules/README.md

@@ -286,7 +286,7 @@ If you are a [SonarQube](https://www.sonarqube.org) or [SonarCloud](https://sona
 | [no-self-compare](https://sonarsource.github.io/rspec/#/rspec/S6679/javascript)                         | "Number.isNaN()" should be used to check for "NaN" value                                                                       | ✅  |     | 💡  |     |     |
 | [no-self-import](https://sonarsource.github.io/rspec/#/rspec/S7060/javascript)                          | Module should not import itself                                                                                                | ✅  |     | 💡  |     |     |
 | [no-skipped-test](https://sonarsource.github.io/rspec/#/rspec/S1607/javascript)                         | Tests should not be skipped without providing a reason                                                                         | ✅  |     |     |     |     |
-| [no-small-switch](https://sonarsource.github.io/rspec/#/rspec/S1301/javascript)                         | "switch" statements should have at least 3 "case" clauses                                                                      | ✅  |     |     |     |     |
+| [no-small-switch](https://sonarsource.github.io/rspec/#/rspec/S1301/javascript)                         | "if" statements should be preferred over "switch" when simpler                                                                 | ✅  |     |     |     |     |
 | [no-tab](https://sonarsource.github.io/rspec/#/rspec/S105/javascript)                                   | Tabulation characters should not be used                                                                                       |     |     |     |     | ❌  |
 | [no-table-as-layout](https://sonarsource.github.io/rspec/#/rspec/S5257/javascript)                      | HTML "<table>" should not be used for layout purposes                                                                    | ✅  |     |     |     |     |
 | [no-this-alias](https://sonarsource.github.io/rspec/#/rspec/S4327/javascript)                           | "this" should not be assigned to variables                                                                                     |     |     |     |     |     |

packages/jsts/src/rules/S1301/meta.ts

@@ -23,7 +23,7 @@
 export const meta = {
   type: 'suggestion',
   docs: {
-    description: '"switch" statements should have at least 3 "case" clauses',
+    description: '"if" statements should be preferred over "switch" when simpler',
     recommended: true,
     url: 'https://sonarsource.github.io/rspec/#/rspec/S1301/javascript',
     requiresTypeChecking: false,

packages/jsts/src/rules/S1607/rule.ts

@@ -33,10 +33,11 @@ import {
   isLiteral,
   isMethodInvocation,
   resolveFunction,
+  toUnixPath,
 } from '../helpers';
 import { meta } from './meta';
 import { TSESTree } from '@typescript-eslint/utils';
-import fs from 'fs';
+import { dirname } from 'path/posix';
 
 export const rule: Rule.RuleModule = {
   meta: generateMeta(meta as Rule.RuleMetaData, {
@@ -53,7 +54,7 @@ export const rule: Rule.RuleModule = {
         return jestListener();
       case dependencies.has('mocha'):
         return mochaListener();
-      case getManifests(context.filename, context.cwd, fs).length > 0:
+      case getManifests(dirname(toUnixPath(context.filename)), context.cwd).length > 0:
         return nodejsListener();
       default:
         return {};

packages/jsts/src/rules/S1607/unit.test.ts

@@ -20,6 +20,7 @@
 import { RuleTester } from 'eslint';
 import { rule } from './';
 
+process.chdir(__dirname); // change current working dir to avoid the package.json lookup to up in the tree
 const ruleTester = new RuleTester();
 
 ruleTester.run(`Tests should not be skipped without providing a reason`, rule, {

packages/jsts/src/rules/S6661/index.ts

@@ -20,15 +20,16 @@
 import { Rule } from 'eslint';
 import { eslintRules } from '../core';
 import { decorate } from './decorator';
-import { isSupported } from '../helpers/validate-version';
+import { dirname } from 'path/posix';
+import { toUnixPath, isSupported } from '../helpers';
 
 const decorated = decorate(eslintRules['prefer-object-spread']);
 
 export const rule: Rule.RuleModule = {
   meta: decorated.meta,
   create(context) {
     // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax#browser_compatibility
-    if (!isSupported(context.filename, { node: '8.3.0' })) {
+    if (!isSupported(dirname(toUnixPath(context.filename)), { node: '8.3.0' })) {
       return {};
     }
 

packages/jsts/src/rules/S6957/rule.ts

@@ -21,10 +21,10 @@
 
 import { Rule } from 'eslint';
 import { rules } from 'eslint-plugin-react';
-import { generateMeta, getManifests } from '../helpers';
+import { generateMeta, getManifests, toUnixPath } from '../helpers';
 import { FromSchema } from 'json-schema-to-ts';
 import { meta, schema } from './meta';
-import path from 'path';
+import { dirname } from 'path/posix';
 
 const reactNoDeprecated = rules['no-deprecated'];
 
@@ -39,7 +39,7 @@ export const rule: Rule.RuleModule = {
       return (context.options as FromSchema<typeof schema>)[0]?.['react-version'];
     }
     function getVersionFromPackageJson() {
-      for (const packageJson of getManifests(path.posix.dirname(context.filename))) {
+      for (const packageJson of getManifests(dirname(toUnixPath(context.filename)), context.cwd)) {
         if (packageJson.dependencies?.react) {
           return packageJson.dependencies.react;
         }

packages/jsts/tests/analysis/analyzer.test.ts

@@ -864,7 +864,10 @@ describe('analyzeJSTS', () => {
       create(context) {
         return {
           CallExpression(node) {
-            const packageJsons = getManifests(path.posix.dirname(context.filename), baseDir);
+            const packageJsons = getManifests(
+              path.posix.dirname(toUnixPath(context.filename)),
+              baseDir,
+            );
             expect(packageJsons).toBeDefined();
             expect(packageJsons[0].name).toEqual('test-module');
             context.report({

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1135.json

@@ -24,7 +24,7 @@
       546
     ]
   },
-  "quickfix": "unknown",
+  "quickfix": "infeasible",
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1441.json

@@ -12,6 +12,12 @@
   "quickfix": "covered",
   "status": "deprecated",
   "tags": [],
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "FORMATTED"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1479.json

@@ -19,7 +19,7 @@
   "ruleSpecification": "RSPEC-1479",
   "sqKey": "S1479",
   "scope": "Main",
-  "quickfix": "unknown",
+  "quickfix": "infeasible",
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1537.json

@@ -12,6 +12,12 @@
   "sqKey": "S1537",
   "scope": "Main",
   "quickfix": "covered",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "LOW"
+    },
+    "attribute": "FORMATTED"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1871.json

@@ -20,7 +20,7 @@
   "ruleSpecification": "RSPEC-1871",
   "sqKey": "S1871",
   "scope": "Main",
-  "quickfix": "unknown",
+  "quickfix": "infeasible",
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S1874.json

@@ -29,7 +29,7 @@
       "1.14.6"
     ]
   },
-  "quickfix": "unknown",
+  "quickfix": "infeasible",
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2260.json

@@ -13,7 +13,14 @@
   "ruleSpecification": "RSPEC-2260",
   "sqKey": "S2260",
   "scope": "Main",
-  "quickfix": "unknown",
+  "quickfix": "infeasible",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM",
+      "RELIABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S2310.json

@@ -12,6 +12,12 @@
   "sqKey": "S2310",
   "scope": "Main",
   "quickfix": "unknown",
+  "code": {
+    "impacts": {
+      "RELIABILITY": "MEDIUM"
+    },
+    "attribute": "CLEAR"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3523.json

@@ -12,6 +12,12 @@
   "sqKey": "S3523",
   "scope": "Main",
   "quickfix": "unknown",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT"
   ]

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S3723.json

@@ -12,6 +12,12 @@
   "sqKey": "S3723",
   "scope": "Main",
   "quickfix": "unknown",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "FORMATTED"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4144.json

@@ -21,7 +21,7 @@
   "ruleSpecification": "RSPEC-4144",
   "sqKey": "S4144",
   "scope": "Main",
-  "quickfix": "unknown",
+  "quickfix": "infeasible",
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S4782.html

@@ -40,11 +40,14 @@ <h2>Why is this an issue?</h2>
   address?: string;
 }
 </pre>
+<p>The rule does not raise any issues when the TypeScript compiler option <code>exactOptionalPropertyTypes</code> is enabled because this option
+ensures that <code>undefined</code> does not become redundant in this context.</p>
 <h2>Resources</h2>
 <h3>Documentation</h3>
 <ul>
   <li> TypeScript Documentation - <a href="https://www.typescriptlang.org/docs/handbook/2/objects.html#optional-properties">Optional Properties</a>
   </li>
   <li> TypeScript Documentation - <a href="https://www.typescriptlang.org/docs/handbook/2/everyday-types.html#union-types">Union Types</a> </li>
+  <li> TypeScript Documentation - <a href="https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes">exactOptionalPropertyTypes</a> </li>
 </ul>
 

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6660.json

@@ -12,6 +12,12 @@
   "sqKey": "S6660",
   "scope": "All",
   "quickfix": "covered",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6661.json

@@ -14,6 +14,12 @@
   "sqKey": "S6661",
   "scope": "All",
   "quickfix": "covered",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6666.json

@@ -12,6 +12,12 @@
   "sqKey": "S6666",
   "scope": "All",
   "quickfix": "covered",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6671.json

@@ -12,6 +12,12 @@
   "sqKey": "S6671",
   "scope": "All",
   "quickfix": "infeasible",
+  "code": {
+    "impacts": {
+      "RELIABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6676.json

@@ -12,6 +12,12 @@
   "sqKey": "S6676",
   "scope": "All",
   "quickfix": "covered",
+  "code": {
+    "impacts": {
+      "MAINTAINABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonar-plugin/javascript-checks/src/main/resources/org/sonar/l10n/javascript/rules/javascript/S6679.json

@@ -12,6 +12,12 @@
   "sqKey": "S6679",
   "scope": "All",
   "quickfix": "covered",
+  "code": {
+    "impacts": {
+      "RELIABILITY": "MEDIUM"
+    },
+    "attribute": "CONVENTIONAL"
+  },
   "compatibleLanguages": [
     "JAVASCRIPT",
     "TYPESCRIPT"

sonarpedia.json

@@ -3,7 +3,7 @@
   "languages": [
     "JS"
   ],
-  "latest-update": "2024-09-17T13:10:19.300365Z",
+  "latest-update": "2024-09-25T13:47:06.983012100Z",
   "options": {
     "no-language-in-filenames": true,
     "preserve-filenames": true