Skip to content

Commit

Permalink
Fix quality flaw
Browse files Browse the repository at this point in the history
  • Loading branch information
pynicolas committed Mar 1, 2016
1 parent 2f8bbdb commit 6e02305
Showing 1 changed file with 4 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@

import static org.fest.assertions.Assertions.assertThat;

import static org.junit.Assert.fail;

public class JavaScriptCheckVerifier extends SubscriptionVisitorCheck {

private final List<TestIssue> expectedIssues = new ArrayList<>();
Expand Down Expand Up @@ -116,10 +118,10 @@ private static Iterator<Issue> getActualIssues(JavaScriptCheck check, JavaScript

private static void verifyIssue(TestIssue expected, Issue actual) {
if (line(actual) > expected.line()) {
throw new AssertionError("Missing issue at line " + expected.line());
fail("Missing issue at line " + expected.line());
}
if (line(actual) < expected.line()) {
throw new AssertionError("Unexpected issue at line " + line(actual) + ": \"" + message(actual) + "\"");
fail("Unexpected issue at line " + line(actual) + ": \"" + message(actual) + "\"");
}
if (expected.message() != null) {
assertThat(message(actual)).as("Bad message at line " + expected.line()).isEqualTo(expected.message());
Expand Down

0 comments on commit 6e02305

Please sign in to comment.