Skip to content

Commit

Permalink
Merge pull request #77 from Space48/fix-default-attempt-deadline
Browse files Browse the repository at this point in the history
Fix deploy error with default attemptDeadline
  • Loading branch information
tgerulaitis authored Feb 4, 2025
2 parents 56e49a7 + f2c53cb commit b148ec0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- Added `cloud-seed run` command to run functions locally with automatic rebuilding on changes. See `README.md` for documentation on how to use this command.
- Cloud Seed commands can now discover the cloudseed.json configuration file for the project when run from within a subdirectory.

### Fixed

- Fixed an "Invalid value" error when deploying `scheduledJob` functions with `attemptDeadline` option set to the default value.

## [v4.0.0](https://github.com/Space48/cloud-seed/compare/v3.0.0...v4.0.0)

### Breaking changes
Expand Down
6 changes: 3 additions & 3 deletions stacks/gcp/GcpStack.ts
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ export default class GcpStack extends TerraformStack {
new cloudSchedulerJob.CloudSchedulerJob(this, "scheduler-" + func.name, {
name: func.name,
schedule: func.schedule,
attemptDeadline: func.attemptDeadline || "3m",
attemptDeadline: func.attemptDeadline || "180s",
timeZone: func.timeZone,
httpTarget: {
uri: (cloudFunc as cloudfunctions2Function.Cloudfunctions2Function).serviceConfig.uri,
Expand Down Expand Up @@ -301,8 +301,8 @@ export default class GcpStack extends TerraformStack {
config.retryOnFailure === undefined
? "RETRY_POLICY_UNSPECIFIED"
: config.retryOnFailure
? "RETRY_POLICY_RETRY"
: "RETRY_POLICY_DO_NOT_RETRY";
? "RETRY_POLICY_RETRY"
: "RETRY_POLICY_DO_NOT_RETRY";

switch (config.type) {
case "queue":
Expand Down

0 comments on commit b148ec0

Please sign in to comment.