-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing page tests #242
base: Dev
Are you sure you want to change the base?
Landing page tests #242
Conversation
…at/seo-add-suspense
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@sonylomo I've fixed the tests. All tests run successfully except one which depends on events data from the API (the API doesn't have any events data as of now) as shown here.: By disabling checking if at least one event card is displayed, all the tests run as expected 👇: @Ase020 I can see your recent PR introduced some linting issue. Haven't had time to go over it, can you kindly address that? Thanks. |
Have you read the contributing guidelines ?
What is the purpose of your pull request?
Proposed changes
Warning
Please read these points carefully and answer honestly with an
X
into all the boxes. Example : [X]
Before submitting a pull request make sure you have:
How to Check and Fix Linting Issues
Run
npm run validate
. This command will run prettier and eslint checks to ensure linting guidelines are respected.If the command exits with code 0 (build is successful), there are no linting issues.
If the command exits with a code other than 0, scroll up the command output and look for identified linting issues. Fix them and revalidate to check if the issues have been resolved by re-running the command.