Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sass color variables #19

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Ebenezr
Copy link

@Ebenezr Ebenezr commented Nov 4, 2022

I'm not sure about some font sizes value found on design file, please review.

@netlify
Copy link

netlify bot commented Nov 4, 2022

Deploy Preview for rio-react ready!

Name Link
🔨 Latest commit cca1f92
🔍 Latest deploy log https://app.netlify.com/sites/rio-react/deploys/6367bbca95059d0008d09f7f
😎 Deploy Preview https://deploy-preview-19--rio-react.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Merging #19 (0d3c2d9) into main (6d3ac81) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #19   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines            8         8           
=========================================
  Hits             8         8           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nyandika
Copy link
Contributor

nyandika commented Nov 5, 2022

Could you like give an example of how we will use this fonts and colors in the components

@Ebenezr
Copy link
Author

Ebenezr commented Nov 5, 2022

Ok, I've updated my PR with documentation on how to use the sass variables

Copy link
Contributor

@nyandika nyandika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this with a caveat for now: caveat being the overall usage we may derive from this in conjunction with tailwind in there as well

@Ebenezr
Copy link
Author

Ebenezr commented Nov 6, 2022

I'm also adding the variables to tailwind config file.

@Ebenezr
Copy link
Author

Ebenezr commented Nov 6, 2022

Updated tailwind config file with design spec color and spacing variables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants