-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sass color variables #19
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for rio-react ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Codecov Report
@@ Coverage Diff @@
## main #19 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 8 8
=========================================
Hits 8 8 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Could you like give an example of how we will use this fonts and colors in the components |
Ok, I've updated my PR with documentation on how to use the sass variables |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this with a caveat for now: caveat being the overall usage we may derive from this in conjunction with tailwind in there as well
I'm also adding the variables to tailwind config file. |
Updated tailwind config file with design spec color and spacing variables |
I'm not sure about some font sizes value found on design file, please review.