[solution proposal] fix(ffe-file-upload-react): håndter iOS bildenavn #2512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hagenek
changed the title
simenaj96
reviewed
Jan 31, 2025
|
|
||
| // Create a unique name for iOS images | ||
| const timestamp = new Date().getTime(); | ||
| const randomString = Math.random().toString(36).substring(2, 8); |
There was a problem hiding this comment.
Bare snakker av erfaring, men kan filnavnet bli for langt? Tenker da på kjernesystemer. Bruker du TS trenger du strengt tatt ikke å legge på en random streng-verdi her.
hagenek
force-pushed
the
file-upload-unikt-navn-ios
branch
2 times, most recently
from
751b3e1 to
26e39a7
Compare
…gelighet - Legg til unik navngenerering for iOS kamerabilder som alltid får navnet 'image.jpg' - Fiks ESLint feil med no-shadow ved å endre parameternavn - Forbedre tilgjengelighet med tastatur og skjermleser støtte - Legg til korrekt ARIA-roller og tastaturfunksjonalitet
hagenek
force-pushed
the
file-upload-unikt-navn-ios
branch
from
26e39a7 to
94635d6
Compare
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2512.westeurope.2.azurestaticapps.net |
simenaj96
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beskrivelse
Motivasjon og kontekst
Testing