Initial NTLM Implementation #177
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvlipka
reviewed
Dec 9, 2024
mvlipka
reviewed
Dec 9, 2024
mvlipka
reviewed
Dec 9, 2024
mvlipka
reviewed
Dec 9, 2024
mvlipka
reviewed
Dec 9, 2024
mvlipka
requested changes
Dec 9, 2024
rvazarkar
commented
Dec 10, 2024
|
recheck |
# Conflicts: # src/CommonLib/LdapConnectionPool.cs
mvlipka
approved these changes
Jan 9, 2025
| throw new ArgumentException("Url property is null"); | ||
|
|
||
| if (useBadChannelBindings == null && url.Scheme == "https") | ||
| throw new ArgumentException("When using HTTPS, useBadChannelBindings must be set"); |
There was a problem hiding this comment.
Nitpicking, but trinary args like this tend to create some funky logic flows that can be hard to follow if you're smooth-brained like I am.
Here I think we're taking on some complexity by managing arg validations that the callers could be doing instead.
I might split this into two functions for clarity: the public function that does everything up to this point, then a private EnsureRequiresAuth(Uri url, bool useBadChannelBindings) that this one calls, feeding the appropriate coerced useBadChannelBindings:
EnsureRequiresAuth(url, useBadChannelBindings ?? true);
definitelynotagoblin
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is the initial implementation of the new NTLM modelling, courtesy of @leechristensen .
Motivation and Context
https://specterops.atlassian.net/browse/BED-5113
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: