Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor neuropixel in a separate file and generate the NP library. #316

Merged
merged 20 commits into from
Jan 27, 2025

Conversation

samuelgarcia
Copy link
Member

@samuelgarcia samuelgarcia commented Jan 21, 2025

The main dict need more validation.

We are missing some probes

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 87.83455% with 50 lines in your changes missing coverage. Please review.

Project coverage is 89.58%. Comparing base (48d759b) to head (b5efca3).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/probeinterface/neuropixels_tools.py 87.80% 50 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #316      +/-   ##
==========================================
+ Coverage   89.46%   89.58%   +0.11%     
==========================================
  Files          11       12       +1     
  Lines        1899     1939      +40     
==========================================
+ Hits         1699     1737      +38     
- Misses        200      202       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alejoe91 alejoe91 merged commit abf0cf0 into SpikeInterface:main Jan 27, 2025
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants