On time info updated #133
Merged
On time info updated #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…terface-gui into on_time_info_updated
alejoe91
commented
May 27, 2025
Comment on lines
+224
to
+228
| self._block_auto_refresh_and_notify = True | ||
| self._qt_change_segment(seg_index) | ||
| self.timeseeker.seek(time) | ||
|
|
||
| self._block_auto_refresh_and_notify = False |
There was a problem hiding this comment.
@samuelgarcia I added this self._block_auto_refresh_and_notify to block any signal and refresh. I tested and there are no recursive refreshes (only 1 per call).
Actually, for QT, when updating the trace, also tracemap needs a refresh because no refresh is triggered when the tab/view becomes active. In Panel, the refresh is not needed since the view is refreshed when selected
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
time_info_updatedsignal, with notifiers and on_ functions. This is mainly used to synchronize times between the controller (which now has aself.time_info) the TraceView and TraceMapView.All
self.seg_index,self.time_by_seghas been replaced by calls to the controllerget_time*functions.The
on_time_info_updatedsyncs the views and widgets to the time info in the controller.