Skip to content

Commit 484f5b7

Browse files
authored
Don't raise when extension is unknown (#4406)
1 parent 177642e commit 484f5b7

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

src/spikeinterface/core/sortinganalyzer.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1943,6 +1943,9 @@ def load_extension(self, extension_name: str):
19431943

19441944
extension_class = get_extension_class(extension_name)
19451945

1946+
if extension_class is None:
1947+
return None
1948+
19461949
extension_instance = extension_class.load(self)
19471950

19481951
self.extensions[extension_name] = extension_instance
@@ -2198,7 +2201,10 @@ def get_extension_class(extension_name: str, auto_import=True):
21982201
f"Extension '{extension_name}' is not registered, please import related module before use: 'import {module}'"
21992202
)
22002203
else:
2201-
raise ValueError(f"Extension '{extension_name}' is unknown maybe this is an external extension or a typo.")
2204+
warnings.warn(
2205+
f"Extension '{extension_name}' is unknown. Maybe this is an external extension, a typo or was computed by a different version of SpikeInterface."
2206+
)
2207+
return None
22022208

22032209
ext_class = extensions_dict[extension_name]
22042210
return ext_class

0 commit comments

Comments
 (0)