Slay: discard duplicates with censor_period_ms in computing RP violations#4530
Draft
alejoe91 wants to merge 29 commits intoSpikeInterface:mainfrom
Draft
Slay: discard duplicates with censor_period_ms in computing RP violations#4530alejoe91 wants to merge 29 commits intoSpikeInterface:mainfrom
censor_period_ms in computing RP violations#4530alejoe91 wants to merge 29 commits intoSpikeInterface:mainfrom
Conversation
chrishalcrow
reviewed
May 1, 2026
Comment on lines
+1693
to
+1698
| merged_acg = ( | ||
| ccgs[unit_index_1, unit_index_1, :] | ||
| + ccgs[unit_index_2, unit_index_2, :] | ||
| + ccgs[unit_index_1, unit_index_2, :] | ||
| + ccgs[unit_index_2, unit_index_1, :] | ||
| ) |
Member
There was a problem hiding this comment.
I don't think this is right. merged_acg later passed to _sliding_RP_viol_pair, a port of the SLAy function _sliding_RP_viol, used here:
In SLAy, x_correlogram computes the cross-correlogram of two units.
This changes the input to be the auto-correlogram of the putative merge.
chrishalcrow
reviewed
May 1, 2026
| }, | ||
| "quality_score": {"firing_contamination_balance": 1.5, "refractory_period_ms": 1.0, "censored_period_ms": 0.3}, | ||
| "slay_score": {"k1": 0.25, "k2": 1, "slay_threshold": 0.5}, | ||
| "slay_score": {"k1": 0.25, "k2": 1, "slay_threshold": 0.5, "censored_period_ms": 0.2}, |
Member
There was a problem hiding this comment.
I'm against changing the default behavior without consulting the SLAy team.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #4498
TODO: