Skip to content

Commit

Permalink
Enable ALSA device monitoring by default
Browse files Browse the repository at this point in the history
Signed-off-by: Christopher Arndt <[email protected]>
  • Loading branch information
SpotlightKid committed Apr 17, 2019
1 parent 7175f09 commit c7581bc
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
6 changes: 3 additions & 3 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@ ChangeLog
------------------

* Detect changes in connected ALSA devices and enable/disable preset,
which use these devices in the menu (behaviour disabled by defult).
* Added command line option ``-a``, ``--alsa-monitor`` to explicitly
turn on ALSA device monitoring and filtering.
which use these devices in the menu.
* Added command line option ``-a``, ``--no-alsa-monitor`` to disable
ALSA device monitoring and filtering.
* Made some logging improvements.


Expand Down
3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ between different audio setups with just two mouse clicks.
Menu entries for presets, which refer to ALSA devices currently not available
(e.g. those provided by USB interfaces, which are currently un-plugged), will
be deactivated. The application will detect changes in the sound device
configuration via udev and update the menu accordingly.
configuration via udev and update the menu accordingly (this behaviour can
be disabled via a command line option).

When you hover with the mouse pointer over the systray icon and JACK is
running, a tooltip will show you the name of the active preset (if known), the
Expand Down
6 changes: 3 additions & 3 deletions jackselect/jackselect.py
Original file line number Diff line number Diff line change
Expand Up @@ -431,8 +431,8 @@ def main(args=None):
from dbus.mainloop.glib import DBusGMainLoop

ap = argparse.ArgumentParser(description=__doc__.splitlines()[0])
ap.add_argument('-a', '--alsa-monitor', action="store_true",
help="Enable ALSA device monitoring and filtering.")
ap.add_argument('-a', '--no-alsa-monitor', action="store_true",
help="Disable ALSA device monitoring and filtering.")
ap.add_argument('-d', '--default', action="store_true",
help="Activate default preset.")
ap.add_argument('-v', '--verbose', action="store_true",
Expand Down Expand Up @@ -463,7 +463,7 @@ def main(args=None):
log.debug("Opening menu...")
client.OpenMenu()
except dbus.DBusException:
JackSelectApp(bus, monitor_devices=args.alsa_monitor)
JackSelectApp(bus, monitor_devices=not args.no_alsa_monitor)
try:
return Gtk.main()
except KeyboardInterrupt:
Expand Down

0 comments on commit c7581bc

Please sign in to comment.