Skip to content

Release/2.5.2 #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [2.5.2] - 2024-06-18

### Fixed

- Ensured that CaptionsTogglePlugin internal state is maintained when reading from localStorage on startup

## [2.5.1] - 2024-04-16

### Fixed
Expand Down
2 changes: 1 addition & 1 deletion dist/SpringRoll-Container-umd.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/SpringRoll-Container-umd.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/index.js.map

Large diffs are not rendered by default.

60 changes: 27 additions & 33 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "springroll-container",
"version": "2.5.1",
"version": "2.5.2",
"description": "The iframe controller for interacting with SpringRoll applications",
"main": "./dist/index.js",
"license": "MIT",
Expand Down Expand Up @@ -29,10 +29,10 @@
"karma-babel-preprocessor": "^8.0.0",
"karma-browserstack-launcher": "^1.5.1",
"karma-chai": "^0.1.0",
"karma-chrome-launcher": "^2.2.0",
"karma-chrome-launcher": "^3.2.0",
"karma-cli": "^2.0.0",
"karma-es6-shim": "^1.0.0",
"karma-firefox-launcher": "^1.1.0",
"karma-firefox-launcher": "^2.1.3",
"karma-html": "^1.0.5",
"karma-mocha": "^2.0.1",
"karma-requirejs": "^1.1.0",
Expand Down
5 changes: 2 additions & 3 deletions src/plugins/CaptionsTogglePlugin.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ export class CaptionsTogglePlugin extends ButtonPlugin {
return;
}

const captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);

this._setMuteProp('captionsMuted', this._captionsButtons, captionsMuted, true);
this._captionsMuted = !!SavedData.read(CaptionsTogglePlugin.captionsToggleKey);
this._setMuteProp('captionsMuted', this._captionsButtons, this._captionsMuted, true);

}.bind(this)
);
Expand Down
Loading