7 construction sequence generation #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…new dependency tables.
- added a domain model feature flag for construction dependencies - made construction sequence calculation depend on this being set - restored the use of the old priorities if not set
2 tasks
|
scp93ch
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
I've read the code and it makes sense. I don't know why some lines in the new CSV files have the "fake" column as "true"? Perhaps that should be explained in the code?
It would be neater to use a set() for the set of predecessor URIs, but it's not worth changing.
I've not run the code but on the basis that you have and the tests you've done, I'm okay with that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added code to calculate CP sequence numbers and output them to the NQ file as values for the core#hasPriority property of each CP.
There is no error checking as yet because that is done in the MS Access Domain Model editor DB - specifically there is a check that the (partial) sequence number can be found for every CP (i.e., the ConstructionPredecessor.csv and ConstructionSuccessor.csv data does not create any CP cycles).
I guess that may need to be added if we move away from using the DB, but that depends on what replaces it, so I decided not to spend time including those checks here.