Update 1-callouts.pillar - DO NOT INTEGRATE - read comment #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re LibC's `time()`, the text says `(We leave it to the reader to look up the definition of the C function and determine the purpose of this argument.)` While the exact mechanism of the function is tangential, I think it's important and non-obvious why one can and should pass `NULL` as the argument to the spec. Indeed, declarations on some hosts do not specify it and the FFI callout seems to work in Pharo without it. If this is explained later in the booklet, we should mention that here; otherwise a more complete explanation would help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
time(), the text says(We leave it to the reader to look up the definition of the C function and determine the purpose of this argument.)While the exact mechanism of the function is tangential, I think it's important and non-obvious why one can and should passNULLas the argument to the spec. Indeed, declarations on some hosts do not specify it and the FFI callout seems to work in Pharo without it. If this is explained later in the booklet, we should mention that here; otherwise a more complete explanation would help1.,1., etc.