Support sending clinician notifications when seeding specific userIds #288
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #284 by enabling clinician notifications to be seeded when specifying specific user IDs via the
userDataparameter in thedefaultSeedfunction.Problem
Previously, when seeding data for specific user IDs using the
userDataarray parameter, the code unconditionally called_seedPatientCollections()for all users. This meant that clinician users would not receive their notification messages (which are generated based on their assigned patients), breaking the seeding functionality for clinicians.Solution
Modified the
userDataseeding loop to check the user type and call the appropriate seeding function:_seedPatientCollections()(preserving existing behavior)_seedClinicianCollections()to properly seed notification messagesThis implementation mirrors the logic already present in the standard seed flow (when seeding all users), ensuring consistency across both seeding paths.
Changes
functions/src/functions/defaultSeed.ts: Updated userData loop to support both patient and clinician user typesfunctions/src/functions/defaultSeed.test.ts: Added test case to verify clinician messages are seeded correctly for specific userIdsTesting
Added a new test case that:
defaultSeedagain with a specific clinician userIdThe implementation passes all linting and build checks.
Related to PR #142
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.