Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ompp cleanup models #575

Merged
merged 2 commits into from
Jan 26, 2024
Merged

Ompp cleanup models #575

merged 2 commits into from
Jan 26, 2024

Conversation

Souheil-Yazji
Copy link
Contributor

No longer copying the sample models from the OMPP release to the buckets, this should also speed up the start-oms.sh script. If needed, those sample models can still be copied over manually.

@Souheil-Yazji Souheil-Yazji added the auto-deploy Trigger manual CI steps for this PR label Jan 23, 2024
@Souheil-Yazji Souheil-Yazji self-assigned this Jan 23, 2024
Copy link
Contributor

@KrisWilliamson KrisWilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@vexingly
Copy link
Contributor

Any downside for a new namespace that will not have any models available? The web interface would just be empty and users will be responsible to compile or manually copy models before they can run/test? It does seem like for the UAT the users were only interested in utilizing their own models and not the sample models.

Copy link
Contributor

@jacek-dudek jacek-dudek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with them not being there. But maybe it would be good to have one sample model in there by default so that when the openm ui starts it's not completely empty.

@Souheil-Yazji
Copy link
Contributor Author

Any downside for a new namespace that will not have any models available? The web interface would just be empty and users will be responsible to compile or manually copy models before they can run/test? It does seem like for the UAT the users were only interested in utilizing their own models and not the sample models.

no downside as the folders will still be created, which means the Dir structure is preserved. This will improve the UX for users.

I'm ok with them not being there. But maybe it would be good to have one sample model in there by default so that when the openm ui starts it's not completely empty.

Honestly, from the perspective of the user, once they have their model in the bucket, it will never be empty.

@Souheil-Yazji Souheil-Yazji merged commit 0587270 into master Jan 26, 2024
7 checks passed
@Souheil-Yazji Souheil-Yazji deleted the ompp-cleanup-models branch January 26, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy Trigger manual CI steps for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants