Skip to content

fix for the notification modal in owners page in mobile view #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rellmon wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix for the notification modal in owners page in mobile view #267

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Components/admin/Owners/Modals/MessageModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,9 +81,15 @@ export default function MessageModal({
}

const rect = anchorRef.current.getBoundingClientRect();
const modalWidth = window.innerWidth < 768 ? window.innerWidth - 32 : 384; // sm: 384px (max-w-sm)
const maxRight = window.innerWidth - rect.right - 16;

// Ensure modal doesn't overflow right edge
const right = Math.max(Math.min(maxRight, window.innerWidth - modalWidth - 16), 16);

setPosition({
top: rect.bottom + 12,
right: Math.max(window.innerWidth - rect.right - 16, 16),
right: right,
});
}

Expand Down Expand Up @@ -141,7 +147,7 @@ export default function MessageModal({
return createPortal(
<div
ref={containerRef}
className="fixed z-[9991] w-full max-w-md md:max-w-sm"
className="fixed z-[9991] w-[calc(100vw-32px)] max-w-sm sm:w-auto"
style={{
top: position.top,
right: position.right,
Expand Down
10 changes: 8 additions & 2 deletions Components/admin/Owners/Modals/NotificationModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,15 @@ export default function NotificationModal({ onClose, onViewAll, anchorRef, userI
}

const rect = anchorRef.current.getBoundingClientRect();
const modalWidth = window.innerWidth < 768 ? window.innerWidth - 32 : 384; // sm: 384px (max-w-sm)
const maxRight = window.innerWidth - rect.right - 16;

// Ensure modal doesn't overflow right edge
const right = Math.max(Math.min(maxRight, window.innerWidth - modalWidth - 16), 16);

setPosition({
top: rect.bottom + 12,
right: Math.max(window.innerWidth - rect.right - 16, 16),
right: right,
});
}

Expand Down Expand Up @@ -135,7 +141,7 @@ export default function NotificationModal({ onClose, onViewAll, anchorRef, userI
return createPortal(
<div
ref={containerRef}
className="fixed z-[9991] w-full max-w-md md:max-w-sm"
className="fixed z-[9991] w-[calc(100vw-32px)] max-w-sm sm:w-auto"
style={{
top: position.top,
right: position.right,
Expand Down