Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LetMeReShade Plugin #757

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Add LetMeReShade Plugin #757

wants to merge 21 commits into from

Conversation

itsOwen
Copy link
Contributor

@itsOwen itsOwen commented Feb 5, 2025

LetMeReShade Plugin

A seamless ReShade integration for Steam Deck that enables advanced shader customization and graphics enhancement. This plugin provides easy ReShade installation, game-specific shader application, and preset management.

Task Checklist

Developer

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

  • No: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • No: I am using a custom binary that has all of it's dependencies statically linked.

Community

  • I have tested and left feedback on two other pull requests for new or updating plugins.
  • I have commented links to my testing report in this PR.

Testing

  • Tested on SteamOS Stable or Beta update channel.

@itsOwen itsOwen requested a review from a team as a code owner February 5, 2025 17:20
@EMERALD0874
Copy link
Member

@itsOwen This plugin has similar issues we're addressing with #751 regarding curl statements being moved to the remote binary system. I'd rather not create standards for what should(n't) be using that system across multiple PRs, so I'm going to hold off on a code review until we're either blocked on that PR or we've agreed on a solution.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to the usage of curl in setup and the downloading of git contents of repositories after install, this plugin immediately fails out standards for approval on the basis of it downloading and extracting assets after first install. Even if these were communicated to the user, this is not passable. Please refer back to the solution that myself and xXJSONDeruloXx worked to arrive at with the Framegen plugin. All needed external assets are downloaded by Decky during install and hashes are used to check those files being downloaded. You are obviously aware of this as your package.json makes use of remote_binary and remote_binary_bundling entries but you seem to have not understood the point of my fixing the implementation to get this working again. All assets must be included in download or an interface with clear moderation and safeguards for downloaded content must be provided if additional downloads of files are performed.

@TrainDoctor TrainDoctor added bug Something isn't working plugin-addition needsfix An issue/change request needs to be resolved and removed bug Something isn't working labels Feb 10, 2025
@itsOwen
Copy link
Contributor Author

itsOwen commented Feb 10, 2025

@TrainDoctor Oh yes I am fixing it cheers mate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needsfix An issue/change request needs to be resolved plugin-addition
Projects
Status: 📋 Backlog
Development

Successfully merging this pull request may close these issues.

3 participants