-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LetMeReShade Plugin #757
base: main
Are you sure you want to change the base?
Conversation
…t not appearing on delly footer
@itsOwen This plugin has similar issues we're addressing with #751 regarding curl statements being moved to the remote binary system. I'd rather not create standards for what should(n't) be using that system across multiple PRs, so I'm going to hold off on a code review until we're either blocked on that PR or we've agreed on a solution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to the usage of curl in setup and the downloading of git contents of repositories after install, this plugin immediately fails out standards for approval on the basis of it downloading and extracting assets after first install. Even if these were communicated to the user, this is not passable. Please refer back to the solution that myself and xXJSONDeruloXx worked to arrive at with the Framegen plugin. All needed external assets are downloaded by Decky during install and hashes are used to check those files being downloaded. You are obviously aware of this as your package.json makes use of remote_binary and remote_binary_bundling entries but you seem to have not understood the point of my fixing the implementation to get this working again. All assets must be included in download or an interface with clear moderation and safeguards for downloaded content must be provided if additional downloads of files are performed.
@TrainDoctor Oh yes I am fixing it cheers mate! |
LetMeReShade Plugin
A seamless ReShade integration for Steam Deck that enables advanced shader customization and graphics enhancement. This plugin provides easy ReShade installation, game-specific shader application, and preset management.
Task Checklist
Developer
Plugin
Backend
Community
Testing