Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MagicPods to 1.0.10 #762

Closed
wants to merge 1 commit into from

Conversation

steam3d
Copy link
Contributor

@steam3d steam3d commented Feb 10, 2025

MagicPods

A magic plugin for the Decky Loader that allows you to control your AirPods and Beats headphones in a comfortable way.

  • Added localization el-GR
  • Added AirPods 4

Task Checklist

Developer

  • I am the original author or an authorized maintainer of this plugin.
  • I have abided by the licenses of the libraries I am utilizing, including attaching license notices where appropriate.

Plugin

  • I have verified that my plugin works properly on the Stable and Beta update channels of SteamOS.
  • I have verified my plugin is unique or provides more/alternative functionality to a plugin already on the store.

Backend

  • Yes: I am using a custom backend other than Python.
  • No: I am using a tool or software from a 3rd party FOSS project that does not have it's dependencies statically linked.
  • Yes: I am using a custom binary that has all of it's dependencies statically linked.

Community

  • I have tested and left feedback on two other pull requests for new or updating plugins.
  • I have commented links to my testing report in this PR.

Testing

  • Tested by a third party on SteamOS Preview update channel.

Sorry, something went wrong.

Copy link
Member

@TrainDoctor TrainDoctor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@steam3d, all changes look good. Good for testing.

As per our new policy meant to encourage the quick testing of plugins, I would request that you submit testing reports for at least 2 other plugin submissions/updates (preferably the oldest PRs still active). Then if no other plugin author (as I will be encouraging all others to do the same) or tester submits a testing report I will request that a member of the SDH team tests your plugin update/submission according to the testing guidelines.

@TrainDoctor TrainDoctor requested review from a team February 10, 2025 21:38
@vladky
Copy link

vladky commented Feb 14, 2025

Plugin Testing Report

Installed Plugins

  • MagicBlack 1.0.2
  • SteamGridDB 1.5.1-loaderv2
  • Memory Deck 0.1.8

Specifications

  • SteamOS 3.6.20 (Stable)
  • Decky v3.0.5 (Stable)

Issues

Has the following major blocking issue(s): None
Has the following minor non-blocking issue(s): None

Summary

Plugin works as expected.

@EMERALD0874
Copy link
Member

EMERALD0874 commented Feb 14, 2025

@vladky While I appreciate the testing report, this plugin requires testing on the preview branch of SteamOS since it uses a custom backend and custom binaries. If you're willing, could you please change branches and send another report?

You may also want to switch to the pre-release track of Decky Loader when testing on SteamOS Preview.

Copy link

This pull request is stale as no updates or testing reports have been posted within the last 7 days. Please ensure you are actively recruiting testers or resolving the issues discussed. If you do not remove the stale label or comment, this will be closed in 7 days. Please close this pull request if you need more time to resolve issues so we can keep our repo healthy.

@github-actions github-actions bot added the stale label Feb 22, 2025
Copy link

github-actions bot commented Mar 1, 2025

Your pull request has been closed for being stale. If you want to resubmit a plugin pull request, please ensure you have a tester for your plugin and have resolved all issues discussed.

@github-actions github-actions bot closed this Mar 1, 2025
@steam3d
Copy link
Contributor Author

steam3d commented Mar 1, 2025

@EMERALD0874 What does this mean? The old pull request was closed. How do I have to update it?

#772 (comment)

@steam3d steam3d mentioned this pull request Mar 1, 2025
7 tasks
@EMERALD0874
Copy link
Member

Replied on Discord and in your new PR. You need to find a tester in your community to proceed. Please follow up with me in one of the two previously mentioned places with further questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants