Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CDN auth #1372

Closed
wants to merge 3 commits into from
Closed

Conversation

oureveryday
Copy link
Contributor

@oureveryday oureveryday commented Jun 30, 2024

Some Steam CDNs in China requires a CDN auth to download.

@yaakov-h
Copy link
Member

This looks like it just passes null around. Where does the actual auth happen?

@oureveryday
Copy link
Contributor Author

oureveryday commented Jun 30, 2024

You need to call CMsgClientGetCDNAuthTokenResponse and get the CDN auth.
Only in Chinese CDNs it will return a non-empty CDN auth string. (Other CDNs will return an empty string)
And if you passed an empty/invaild CDN auth string to Chinese CDN, it will return a 403 error.

@xPaw
Copy link
Member

xPaw commented Jul 25, 2024

For reference, CDN auth code was removed in #1022.

@oureveryday
Copy link
Contributor Author

You still need to use a CDN auth to download in Chinese CDNs.

@xPaw
Copy link
Member

xPaw commented Jul 25, 2024

I know, I am providing a reference as to where it was removed, and you can take a look at how it was implemented before.

You should add a xmldoc for the auth argument and how to get one (GetCDNAuthToken).

@xPaw xPaw closed this in 9ed08d4 Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants