-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File structure refactoring, fixed AppUser streaming via Provider #55
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few changes from the errors I observed. Also, we probably don't care right now but we will see an error if user created an account without first name and last name set correctly, so we just need to be wary of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go. Merging..
* File structure refactoring, fixed AppUser streaming via Provider * Small Provider bug fix * edited signup first name and last name mapping * Changes from PR comments --------- Co-authored-by: Tobias Beidler-Shenk <[email protected]>, Jeffrey Zheng <[email protected]>
Changes
AppUser
stream inMultiProvider
in main.dart in order to stream the user's data from Firestore based on the auth userFirestoreService
andAuthService
to have only static methods (we were instancing these classes when we needed to use their methods, it didn't really make sense)Notes
I think the way I did change # 4 is kind of bad let me know if you don't get what I did or have a better idea of how to do it. Also you can verify that the AppUser stream is working by looking in ProfilePage, it loads the first name of the user which is one of the fields that is only stored in Firestore, not in Firebase Auth