Skip to content

Allow direct subtitle delay entry#1294

Draft
Tavaresiqueira wants to merge 1 commit into
Stremio:developmentfrom
Tavaresiqueira:feature/subtitle-delay-direct-entry
Draft

Allow direct subtitle delay entry#1294
Tavaresiqueira wants to merge 1 commit into
Stremio:developmentfrom
Tavaresiqueira:feature/subtitle-delay-direct-entry

Conversation

@Tavaresiqueira

Copy link
Copy Markdown

Summary

This makes the subtitle delay value in the player subtitles menu directly editable while keeping the existing +/- buttons at 0.25s increments.

The motivation is a real playback case where subtitles were more than 40 seconds out of sync. With only 0.25s steps, reaching the rough offset requires too many repeated clicks before fine tuning can even start.

Behavior

  • Users can type the delay in seconds directly in the existing delay stepper.
  • Enter or blur commits the typed value; Escape restores the current value.
  • The +/- buttons still adjust by 0.25s for precise tuning after the rough offset is entered.
  • Size and vertical position steppers remain display-only values with buttons, matching their previous behavior.
  • The existing subtitleDelay stream state path is unchanged, so remembered subtitle timing continues to work as before.

Validation

  • npx --yes pnpm@10.12.1 lint
  • npx --yes pnpm@10.12.1 build

The production build still reports the existing webpack asset/entrypoint size warnings.

Make the subtitle delay stepper optionally editable so users can type a large offset directly, such as a 40 second subtitle drift, while preserving the existing 0.25 second increment controls for fine tuning.

The delay menu keeps using the existing subtitleDelay stream state path, so remembered subtitle timing behavior stays unchanged and no new shortcut or settings surface is introduced.
@CLAassistant

CLAassistant commented Jun 1, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@kKaskak

kKaskak commented Jun 1, 2026

Copy link
Copy Markdown
Member

you can hold the button to fast forward to the value you want tho?

@kKaskak

kKaskak commented Jun 1, 2026

Copy link
Copy Markdown
Member

The motivation is a real playback case where subtitles were more than 40 seconds out of sync. With only 0.25s steps, reaching the rough offset requires too many repeated clicks before fine tuning can even start.

this not true explained in the comment before

@joao-siqueira-genoa

Copy link
Copy Markdown

The motivation is a real playback case where subtitles were more than 40 seconds out of sync. With only 0.25s steps, reaching the rough offset requires too many repeated clicks before fine tuning can even start.

this not true explained in the comment before

You're right, the PR description is too strong there. Holding the button means the user does not need repeated individual clicks, so I should not phrase it as only 0.25s manual steps.

The gap I wanted to solve is narrower: when the user already knows the delay is very large, e.g. around 40s, direct entry is still faster and more precise than holding and trying not to overshoot. The existing hold-to-repeat and 0.25s +/- controls remain useful for fine tuning.

I can update the PR description to make that distinction clear, or close the PR if you think hold-to-repeat is enough for this UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants