Allow direct subtitle delay entry#1294
Conversation
Make the subtitle delay stepper optionally editable so users can type a large offset directly, such as a 40 second subtitle drift, while preserving the existing 0.25 second increment controls for fine tuning. The delay menu keeps using the existing subtitleDelay stream state path, so remembered subtitle timing behavior stays unchanged and no new shortcut or settings surface is introduced.
|
you can hold the button to fast forward to the value you want tho? |
this not true explained in the comment before |
You're right, the PR description is too strong there. Holding the button means the user does not need repeated individual clicks, so I should not phrase it as only 0.25s manual steps. The gap I wanted to solve is narrower: when the user already knows the delay is very large, e.g. around 40s, direct entry is still faster and more precise than holding and trying not to overshoot. The existing hold-to-repeat and 0.25s +/- controls remain useful for fine tuning. I can update the PR description to make that distinction clear, or close the PR if you think hold-to-repeat is enough for this UX. |
Summary
This makes the subtitle delay value in the player subtitles menu directly editable while keeping the existing +/- buttons at 0.25s increments.
The motivation is a real playback case where subtitles were more than 40 seconds out of sync. With only 0.25s steps, reaching the rough offset requires too many repeated clicks before fine tuning can even start.
Behavior
subtitleDelaystream state path is unchanged, so remembered subtitle timing continues to work as before.Validation
npx --yes pnpm@10.12.1 lintnpx --yes pnpm@10.12.1 buildThe production build still reports the existing webpack asset/entrypoint size warnings.